Fix OtelInternalJavadoc diagnostic message to match the contains check#8590
Draft
thswlsqls wants to merge 1 commit into
Draft
Fix OtelInternalJavadoc diagnostic message to match the contains check#8590thswlsqls wants to merge 1 commit into
thswlsqls wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8589
Description
OtelInternalJavadocmatches when the internal disclaimer is absent usingjavadoc.contains(...)(lines 53-56), but the@BugPatternsummary said the class "doesn't end with" the disclaimer.OtelImplJavadoc, which already describes the same.contains()logic accurately ("is missing the required javadoc disclaimer").Testing done
// BUG: Diagnostic contains:assertions inOtelInternalJavadocTest#positiveCasesto match the new message../gradlew :custom-checks:check— passed.custom-checksis an unpublished build module (no maven-publish), so there is no japicmp/apidiff and no CHANGELOG entry (the message is build-time contributor-facing, not user-facing).