Fix stale parameter name in JcTools.drain Javadoc#8513
Conversation
The @throws clause referenced maxExportBatchSize, a parameter that does not exist on drain(Queue, int, Consumer). It was left over from the private drainNonJcQueue helper removed in open-telemetry#7691. Point it at the actual parameter, limit. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
One or more co-authors of this pull request were not found. You must specify co-authors in commit message trailer via: Supported
Alternatively, if the co-author should not be included, remove the Please update your commit message(s) by doing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8513 +/- ##
=========================================
Coverage 78.77% 78.77%
Complexity 8579 8579
=========================================
Files 1009 1009
Lines 28993 28993
Branches 3599 3599
=========================================
Hits 22839 22839
Misses 5311 5311
Partials 843 843 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This has been automatically marked as stale because it has been marked as needing author feedback and has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment. |
Description
JcTools.drain(Queue, int, Consumer)documents@throws IllegalArgumentException if maxExportBatchSize is negative, but nomaxExportBatchSizeparameter exists; the argument islimit.drainNonJcQueue(..., int maxExportBatchSize, ...)helper removed in Proactively avoid Unsafe on Java 23+ #7691. The thrown behavior is unchanged: the delegateMessagePassingQueue.drain(Consumer, int)throwsIllegalArgumentExceptionfor a negative limit.:sdk:trace-shaded-depsmodule; no signature, behavior, or public API change.Testing done
./gradlew :sdk:trace-shaded-deps:checkpassed.