Bound OkHttp sender dispatchers and surface rejections#8422
Open
ADITYA-CODE-SOURCE wants to merge 1 commit into
Open
Bound OkHttp sender dispatchers and surface rejections#8422ADITYA-CODE-SOURCE wants to merge 1 commit into
ADITYA-CODE-SOURCE wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8422 +/- ##
============================================
+ Coverage 90.83% 91.13% +0.30%
+ Complexity 7927 7764 -163
============================================
Files 895 881 -14
Lines 23872 23419 -453
Branches 2378 2331 -47
============================================
- Hits 21683 21344 -339
+ Misses 1446 1380 -66
+ Partials 743 695 -48 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix#8316.
Why
Integer.MAX_VALUEmax threads.What
maxRequestsboundRejectedExecutionExceptionfromenqueue(...)in both HTTP and gRPC sendersTesting
./gradlew --no-daemon --max-workers=1 -Dorg.gradle.jvmargs="-Xmx512m -XX:MaxMetaspaceSize=192m" :exporters:sender:okhttp:spotlessCheck./gradlew --no-daemon --max-workers=1 -Dorg.gradle.jvmargs="-Xmx768m -XX:MaxMetaspaceSize=256m" :exporters:sender:okhttp:test --tests io.opentelemetry.exporter.sender.okhttp.internal.OkHttpUtilTest --tests io.opentelemetry.exporter.sender.okhttp.internal.OkHttpHttpSenderTest --tests io.opentelemetry.exporter.sender.okhttp.internal.OkHttpGrpcSenderTest(fails locally on this Windows machine because Gradle worker JVMs hit paging-file / native memory limits before the module finishes compiling; pushing to CI for full verification)