Add assertion support for Span hasException(null) #8033
Merged
+15
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
hasException(null)is called, it now asserts that the span has no exception event instead of throwing a NullPointerException.This would be convenient in open-telemetry/opentelemetry-java-instrumentation#16049, e.g. when chaining:
I think the behavior reasonably follows convention:
hasSchemaUrl(@Nullable String)asserts the schema URL equals the given value (including null)hasBody(@Nullable Value<?>)asserts the body equals the given value (including null)equalTo(key, null)inhasAttributesSatisfyingExactlyasserts the attribute value is null/absentThis last one we use heavily in instrumentation repo, e.g.