Skip to content

Update LongLastValueAggregator algo to avoid allocations #8017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jack-berg merged 1 commit into from
Jan 28, 2026
Merged

Update LongLastValueAggregator algo to avoid allocations #8017

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions ...c/main/java/io/opentelemetry/sdk/metrics/internal/aggregator/LongLastValueAggregator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import java.util.Collection;
import java.util.List;
import java.util.Objects;
import java.util.concurrent.atomic.AtomicLong;
import java.util.concurrent.atomic.AtomicReference;
import javax.annotation.Nullable;

Expand Down Expand Up @@ -88,8 +89,8 @@ public MetricData toMetricData(
}

static final class Handle extends AggregatorHandle<LongPointData> {
@Nullable private static final Long DEFAULT_VALUE = null;
private final AtomicReference<Long> current = new AtomicReference<>(DEFAULT_VALUE);
private final AtomicReference<AtomicLong> current = new AtomicReference<>(null);
private final AtomicLong value = new AtomicLong();

// Only used when memoryMode is REUSABLE_DATA
@Nullable private final MutableLongPointData reusablePoint;
Expand All @@ -110,21 +111,22 @@ protected LongPointData doAggregateThenMaybeResetLongs(
Attributes attributes,
List<LongExemplarData> exemplars,
boolean reset) {
Long value = reset ? this.current.getAndSet(DEFAULT_VALUE) : this.current.get();

AtomicLong value =
Objects.requireNonNull(reset ? this.current.getAndSet(null) : this.current.get());
long currentValue = value.get();
if (reusablePoint != null) {
reusablePoint.set(
startEpochNanos, epochNanos, attributes, Objects.requireNonNull(value), exemplars);
reusablePoint.set(startEpochNanos, epochNanos, attributes, currentValue, exemplars);
return reusablePoint;
} else {
return ImmutableLongPointData.create(
startEpochNanos, epochNanos, attributes, Objects.requireNonNull(value), exemplars);
startEpochNanos, epochNanos, attributes, currentValue, exemplars);
}
}

@Override
protected void doRecordLong(long value) {
current.set(value);
this.value.set(value);
this.current.compareAndSet(null, this.value);
}
}
}
Loading