Skip to content

Relax brittle OATS log attribute assertions #1150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zeitlinger wants to merge 2 commits into
base: renovate/opentelemetry-instrumentation-packages
Choose a base branch
from
+10 −4
Open

Relax brittle OATS log attribute assertions #1150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d094ee8
Relax brittle OATS log attribute assertions
zeitlinger May 26, 2026
c5d20e9
Log dice container mountinfo for CI debugging
zeitlinger May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion logging-k8s-stdout-otlp-json/k8s/dice.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,16 @@ spec:
- name: dice
image: dice:1.1-SNAPSHOT
imagePullPolicy: Never
command:
- /bin/sh
- -c
args:
- |
echo "=== /proc/self/mountinfo ==="
cat /proc/self/mountinfo
echo "=== /proc/self/cgroup ==="
cat /proc/self/cgroup
exec java -jar ./app.jar
Comment on lines +31 to +40
Copy link
Copy Markdown
Contributor

@laurit laurit May 26, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be removed? or do you believe it could be useful in the future?

ports:
- containerPort: 8080
env:
Expand All @@ -45,4 +55,3 @@ spec:
value: "true"
- name: SERVICE_NAME
value: dice

3 changes: 0 additions & 3 deletions logging-k8s-stdout-otlp-json/oats.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ expected:
# thread_name: ".*" # thread name is missing when there is an exception - has nothing to do with stdout logging
span_id: ".*"
trace_id: ".*"
container_id: ".*"
host_arch: ".*"
host_name: ".*"
os_description: ".*"
Expand All @@ -52,5 +51,3 @@ expected:
telemetry_sdk_version: ".*"
exception_stacktrace: "java\\.lang\\.RuntimeException: simulating an error\n\tat io\\.opentelemetry\\.example\\.RollController\\.index\\(RollController\\.java:21\\)\n\t.*\n"

no-extra-attributes: true

Loading