Skip to content

[dynamic control] enable autoconfigurable extension#2866

Open
jackshirazi wants to merge 3 commits into
open-telemetry:mainfrom
jackshirazi:policy28
Open

[dynamic control] enable autoconfigurable extension#2866
jackshirazi wants to merge 3 commits into
open-telemetry:mainfrom
jackshirazi:policy28

Conversation

@jackshirazi
Copy link
Copy Markdown
Contributor

Description:

Initial Telemetry policy implementation is done with one policy supported (sampling rate changes), this enables the extension to be autoconfigurable

Existing Issue(s):

#2416

Testing:

Manually tested as working end-to-end with changes

Documentation:

To be added

Outstanding items:

  1. Documentation on how to use the extension with autoconfiguration
  2. Enabling the extension to be used with declarative config instead of autoconfiguration (needs a ComponentProvider and a DeclarativeCustomizerProvider, PR is blocked on [dynamic control] Register implementers #2858)
  3. Documentation on how to use the extension with declarative config
  4. Further policies added
  5. Further sources implemented (File and HTTP)
  6. Align to spec (current implementation has drifted in some areas)
  7. Implement TODOs
  8. Declarative config telemetry policy node semconv
  9. Telemetry policy names semconv

Copilot AI review requested due to automatic review settings May 26, 2026 12:06
@jackshirazi jackshirazi requested a review from a team as a code owner May 26, 2026 12:06
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds dynamic policy initialization during OpenTelemetry auto-configuration and strengthens the corresponding unit test to validate customization behavior.

Changes:

  • Invoke PolicyInit.init(...) from DynamicControlAutoConfiguration.customize(...).
  • Update DynamicControlAutoConfigurationTest to verify a properties customizer is registered.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
dynamic-control/src/main/java/io/opentelemetry/contrib/dynamic/DynamicControlAutoConfiguration.java Initializes dynamic policy registry during agent auto-configuration.
dynamic-control/src/test/java/io/opentelemetry/contrib/dynamic/DynamicControlAutoConfigurationTest.java Replaces “no-throw” comment with a Mockito verification of expected customization behavior.

jackshirazi and others added 2 commits May 26, 2026 13:22
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@github-actions github-actions Bot requested a review from LikeTheSalad May 26, 2026 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants