fix: grpc client call panic#2981
Open
quanbisen wants to merge 2 commits intoopen-telemetry:mainfrom
Open
Conversation
|
RonFed
reviewed
Nov 9, 2025
Contributor
RonFed
left a comment
RonFed
left a comment
There was a problem hiding this comment.
I'm not sure I understand the rationale for this fix. It seems like this changes some local variables to be stored on storage maps but these maps are accessed within the same function - so I'm not sure how that helps.
Author
but it work for me now, I'm sure it fix grpc call panic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I used Cursor to fix a bug in the gRPC client call that occasionally triggered panics. After the fix, it has been running stably for 3 days without any issues. Before the fix, the program would panic within a day. While this fix resolved the gRPC panic issue, I'm unsure if the changes might affect other functionalities – though my current tests show no problems.