feat(crosslink): accept go patch versions#1499
Merged
dmathieu merged 2 commits intoopen-telemetry:mainfrom Mar 6, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1499 +/- ##
=======================================
Coverage 64.07% 64.07%
=======================================
Files 66 66
Lines 3435 3435
=======================================
Hits 2201 2201
Misses 993 993
Partials 241 241 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
txabman42
force-pushed
the
crosslink-valid-patch-version
branch
from
d69a61e to
eda2e61
Compare
txabman42
changed the title
Contributor
Author
dmathieu
approved these changes
Mar 6, 2026
Member
dmathieu
left a comment
dmathieu
left a comment
There was a problem hiding this comment.
While this looks good to me, we typically don't use patch versions for Go in any of our projects. Where do you need this?
Contributor
Author
|
I wanted to use crosslink in opentelemetry-go-compile-instrumentation. Our go.mod uses |
mx-psi
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support go patch versions in crosslink