Add support for cgroup v1 #992
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Extends container ID extraction to support both cgroup v1 and v2, instead of only supporting cgroup v2.
Motivation
The current implementation only supported cgroup v2 container ID extraction. In really, the current code supports in some way cgroup v1 because old regex
regexp.MustCompile(0:.?:.?([0-9a-fA-F]{64})(?:.scope)?(?:/[a-z]+)?$)match line such as (The regex doesn't start with^.Describe how you validated your changes
Added unit tests for cgroup v1 scenarios.
Check container extraction on cgroup v1 / v2
Additional Notes
The implementation is inspired by the dd-otel-host-profiler approach with modifications to handle the specific test cases in this codebase.