Rename tpbase package to libc, update hooks and calls accordingly #952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalehamel
force-pushed
the
rename-tpbase-libc
branch
from
e868df1 to
7e6c654
Compare
dalehamel
commented
Nov 10, 2025
|
|
||
| // Also gather TSD info if applicable. | ||
| if tpbase.IsPotentialTSDDSO(elfRef.FileName()) { | ||
| if libc.IsPotentialTSDDSO(elfRef.FileName()) { |
Contributor
Author
There was a problem hiding this comment.
This function is now a bit awkwardly named, but it can potentially match libpthread, so changing constitutes an actual change to the logic. For now, i'm leaving it as-is.
florianl
approved these changes
Nov 11, 2025
fabled
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per feedback from @fabled on #929:
This should not contain any functionality changes, it is just renaming
tpbasepackage to more generically belibc, and the existingTSDInfostruct is nested within a more genericLibcInfostruct as a field. Existing hooks referring to TSDInfo also now more generically refer to LibcInfo.This is to prepare for adding DTV info to the LibcInfo struct, and potentially other libc specific data in the future.