Skip to content

Add support for KVList values in TagWriter#6812

Closed
slang25 wants to merge 3 commits intoopen-telemetry:mainfrom
slang25:kvlist
Closed

Add support for KVList values in TagWriter#6812
slang25 wants to merge 3 commits intoopen-telemetry:mainfrom
slang25:kvlist

Conversation

@slang25
Copy link
Copy Markdown

@slang25 slang25 commented Jan 7, 2026

Fixes #
Design discussion issue #

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Jan 7, 2026

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions github-actions Bot added the pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package label Jan 7, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.88%. Comparing base (866e218) to head (ae09b80).
⚠️ Report is 54 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6812      +/-   ##
==========================================
- Coverage   86.88%   86.88%   -0.01%     
==========================================
  Files         262      262              
  Lines       12350    12349       -1     
==========================================
- Hits        10730    10729       -1     
  Misses       1620     1620              
Flag Coverage Δ
unittests-UnstableCoreLibraries-Experimental 86.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...xporter.Console/Implementation/ConsoleTagWriter.cs 10.00% <ø> (ø)
...Implementation/Serializer/ProtobufOtlpTagWriter.cs 95.89% <ø> (-0.06%) ⬇️
....Exporter.Zipkin/Implementation/ZipkinTagWriter.cs 60.86% <ø> (ø)

@github-actions github-actions Bot added pkg:OpenTelemetry.Exporter.Console Issues related to OpenTelemetry.Exporter.Console NuGet package pkg:OpenTelemetry.Exporter.Zipkin Issues related to OpenTelemetry.Exporter.Zipkin NuGet package pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package labels Jan 7, 2026
@rajkumar-rangaraj
Copy link
Copy Markdown
Member

Thanks for the contribution!

This PR modifies the attribute serialization hot path (TryWriteTag), which executes for every attribute on every telemetry item. Could you run the existing OpenTelemetry.Exporter.OpenTelemetryProtocol.Benchmarks and share before/after results?

What's the motivation?

I don't see a linked issue. I'd recommend creating an issue first to drive clarity on:

  1. Which backends actually benefit from kvlist over JSON string?
  2. What's the OTel spec guidance on when to use kvlist vs string?

This will help us align on whether this is the right approach before investing more time in the implementation.

@github-actions
Copy link
Copy Markdown
Contributor

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or pushing will instruct the bot to automatically remove the label. This bot runs once per day.

@github-actions github-actions Bot added Stale Issues and pull requests which have been flagged for closing due to inactivity and removed Stale Issues and pull requests which have been flagged for closing due to inactivity labels Jan 15, 2026
@github-actions
Copy link
Copy Markdown
Contributor

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or pushing will instruct the bot to automatically remove the label. This bot runs once per day.

@github-actions github-actions Bot added Stale Issues and pull requests which have been flagged for closing due to inactivity and removed Stale Issues and pull requests which have been flagged for closing due to inactivity labels Jan 23, 2026
@github-actions
Copy link
Copy Markdown
Contributor

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or pushing will instruct the bot to automatically remove the label. This bot runs once per day.

@github-actions github-actions Bot added the Stale Issues and pull requests which have been flagged for closing due to inactivity label Jan 31, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 7, 2026

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions Bot closed this Feb 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:OpenTelemetry.Exporter.Console Issues related to OpenTelemetry.Exporter.Console NuGet package pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package pkg:OpenTelemetry.Exporter.Zipkin Issues related to OpenTelemetry.Exporter.Zipkin NuGet package pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package Stale Issues and pull requests which have been flagged for closing due to inactivity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants