[OTLP] Add TLS-only support to OTLP HTTP client factory#6799
[OTLP] Add TLS-only support to OTLP HTTP client factory#6799Kielek merged 13 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6799 +/- ##
==========================================
+ Coverage 86.86% 86.94% +0.08%
==========================================
Files 262 263 +1
Lines 12355 12382 +27
==========================================
+ Hits 10732 10766 +34
+ Misses 1623 1616 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@sandy2008 I have provided some important feedback. Please let me know once you have addressed these points. |
|
@rajkumar-rangaraj Please kindly review again, tyvm! And happy new year! |
# Conflicts: # src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Implementation/OtlpCertificateManager.cs
|
@sandy2008 Happy new year! One question: the CA certificate is now recreated from using var caCert = new X509Certificate2(caCertData);Does this create and dispose a new |
Happy New Year! 🎉 In short:
|
rajkumar-rangaraj
left a comment
There was a problem hiding this comment.
LGTM
One minor suggestion: consider adding a brief comment explaining why CRL/OCSP checks are skipped for custom CA validation (commit 20acada)
…k-dependent failures
@rajkumar-rangaraj done! |
…r custom CA validation
…rted for graceful test handling on unsupported platforms
|
@rajkumar-rangaraj do you think we can get it merged as well~~ Tyvm!! |
|
@sandy2008, thanks! Queued for merging. |
|
Thank you for your contribution @sandy2008! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. |
Thank you very much! I also got open-telemetry/opentelemetry-python#4116 merged in Python (mTLS), |
|
@sandy2008, sure, I can be one of your sponsors. |
|
@sandy2008 If more sponsors are need, include me. Thanks! |
|
@Kielek @rajkumar-rangaraj Thank you so much! I added in open-telemetry/community#3222 :) |
Fixes #6764
Design discussion issue #6764
Changes
Add TLS-only support to the OTLP HTTP client factory while keeping mTLS behavior. Introduces
OtlpTlsOptions, updates certificate loading/validation flow for CA-only and mTLS scenarios, and expands tests to cover TLS configuration paths.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes