Add experimental OpAMP client by RassK · Pull Request #4486 · open-telemetry/opentelemetry-dotnet-instrumentation

RassK · 2025-09-29T20:09:28Z

What

Adds experimental opamp client.
Registers client to the server (http/s or ws/s).
More info in contrib repo:
https://github.com/open-telemetry/opentelemetry-dotnet-contrib/tree/main/src/OpenTelemetry.OpAmp.Client

Tests

Build was locally tested.
Additional tools are unit tested.

http connection is integration tested. (websocket is tested in contrib side, let me know if anyone feels it's important to have ws tests in this repo as well).

Checklist

CHANGELOG.md is updated.
Documentation is updated.
New features are covered by tests.

# Conflicts: # src/OpenTelemetry.AutoInstrumentation/Configurations/GeneralSettings.cs

Kielek

I have 2 concerns here

New transitive dependencies.
- Google.Protobuf was already removed from the distribution in scope of update od OTel ADK to 1.11.0: 3986
- System.Collections.Immutable - Do you any possibility to drop this dependency in Opam.Client package?
Lack of integration tests with OpAmp server. I see 2 options here
- create mocked server as we have for OTLP protocol
- Utilize some existing dockerized server.
  Adding this kind of tests can be done as follow up PR.

RassK · 2025-09-30T08:35:52Z

I have 2 concerns here

New transitive dependencies.

Google.Protobuf was already removed from the distribution in scope of update od OTel ADK to 1.11.0: 3986

I was looking what OpenTelemetry.Exporter.OpenTelemetryProtocol was doing. This experience could be transferred to OpAMP client as well.

System.Collections.Immutable - Do you any possibility to drop this dependency in Opam.Client package?

Probably not. This may have to stay.
Update: @Kielek found a way to fix it, so we can go fully without deps

Lack of integration tests with OpAmp server. I see 2 options here

create mocked server as we have for OTLP protocol

Utilize some existing dockerized server.
Adding this kind of tests can be done as follow up PR.

I could reuse OpAMP Go's example server.

ysolomchenko

I believe it makes sense to create separate settings for OpAMP and handle calculations there (ConnectionType and ServerUrl). This would allow us :

Keep code consistency
Add file-based configuration

RassK · 2025-09-30T09:17:34Z

I believe it makes sense to create separate settings for OpAMP and handle calculations there (ConnectionType and ServerUrl). This would allow us :

Keep code consistency

Add file-based configuration

Yes, this seems good change for this PR even.

RassK · 2025-10-01T15:38:59Z

Moving to draft. The plan is to implement the next version without deps.

# Conflicts: # docs/file-based-configuration.md # src/Directory.Packages.props # src/OpenTelemetry.AutoInstrumentation.Assemblies.NetFramework/Directory.Packages.props # src/OpenTelemetry.AutoInstrumentation.Native/netfx_assembly_redirection.h # src/OpenTelemetry.AutoInstrumentation/Configurations/FileBasedConfiguration/YamlConfiguration.cs # src/OpenTelemetry.AutoInstrumentation/Instrumentation.cs # test/IntegrationTests/BuildTests.DistributionStructure_alpine-linux-arm64.verified.txt # test/IntegrationTests/BuildTests.DistributionStructure_alpine-linux-x64.verified.txt # test/IntegrationTests/BuildTests.DistributionStructure_linux-arm64.verified.txt # test/IntegrationTests/BuildTests.DistributionStructure_linux-x64.verified.txt # test/IntegrationTests/BuildTests.DistributionStructure_osx.verified.txt # test/IntegrationTests/BuildTests.DistributionStructure_windows.verified.txt

lachmatt · 2026-01-28T17:16:07Z

Blocked at the moment by: #4783

# Conflicts: # src/Directory.Packages.props # src/OpenTelemetry.AutoInstrumentation.Assemblies.NetFramework/Directory.Packages.props # src/OpenTelemetry.AutoInstrumentation.Native/netfx_assembly_redirection.h # src/OpenTelemetry.AutoInstrumentation/Instrumentation.cs # test/IntegrationTests/BuildTests.DistributionStructure_alpine-linux-arm64.verified.txt # test/IntegrationTests/BuildTests.DistributionStructure_alpine-linux-x64.verified.txt # test/IntegrationTests/BuildTests.DistributionStructure_linux-arm64.verified.txt # test/IntegrationTests/BuildTests.DistributionStructure_linux-x64.verified.txt # test/IntegrationTests/BuildTests.DistributionStructure_osx.verified.txt # test/IntegrationTests/BuildTests.DistributionStructure_windows.verified.txt

Co-authored-by: Piotr Kiełkowicz <pkiekowicz@splunk.com>

# Conflicts: # src/Directory.Packages.props

Copilot

Pull request overview

Copilot reviewed 28 out of 28 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ysolomchenko · 2026-04-09T12:28:52Z

I believe it’s worth adding parser tests for the file-based opamp

…-dotnet-instrumentation into opamp-client

Kielek

#4486 (comment)

ysolomchenko · 2026-04-10T07:23:01Z

+``` yaml
+opamp/development:
+  # Configure if OpAMP client is enabled.
+  # If omitted or null, the client is disabled.
+  enabled: false
+  # Configure the server endpoint. If not explicitly set, a default
+  # URL is used: https://localhost:4318/v1/opamp.
+  server_url: https://localhost:4318/v1/opamp
+```


Remove enabled from opamp file based. Typically, if the node is available, it means that it is enabled. To disable, you should remove whole node.

discussions moved forward, there is even better version > open-telemetry/opentelemetry-configuration#544 (comment)

@ysolomchenko removed enabled for now. Spec seems to be moving slowly, so we may change it later then.

# Conflicts: # src/Directory.Packages.props # src/OpenTelemetry.AutoInstrumentation.Assemblies/Directory.Packages.props # src/OpenTelemetry.AutoInstrumentation.Native/assembly_redirection_net.h # src/OpenTelemetry.AutoInstrumentation.Native/assembly_redirection_netfx.h

Copilot

Pull request overview

Copilot reviewed 35 out of 35 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

0.3.0-alpha.1 package should be safe to use

RassK added 4 commits September 25, 2025 14:56

Add opamp client

d1263e3

update config docs

2abef30

Update changelog

eb53894

Merge branch 'main' into opamp-client

043ba6d

# Conflicts: # src/OpenTelemetry.AutoInstrumentation/Configurations/GeneralSettings.cs

RassK requested a review from a team as a code owner September 29, 2025 20:09

RassK added 4 commits September 29, 2025 23:11

update cspell

7be0c49

Merge branch 'main' into opamp-client

04b4d20

update windows distribution structure

4b12332

update structure files

50bb12d

Kielek reviewed Sep 30, 2025

View reviewed changes

RassK closed this Sep 30, 2025

RassK reopened this Sep 30, 2025

Merge branch 'main' into opamp-client

f1a3399

ysolomchenko reviewed Sep 30, 2025

View reviewed changes

RassK marked this pull request as draft October 1, 2025 15:39

RassK added 7 commits October 30, 2025 12:15

Merge branch 'main' into opamp-client

5935b8b

fix configuration

aa10cd1

delay parsing

caf611e

update

cb089d4

fix missing lib

bf6fcff

fix spacing

7531944

Merge branch 'main' into opamp-client

b33600f

RassK mentioned this pull request Nov 4, 2025

GenerateNetFxTransientDependencies does not remove packages #4584

Closed

RassK added 2 commits November 26, 2025 12:08

upgrade the client

d325023

RassK and others added 6 commits April 9, 2026 12:00

remove todo

ac55ead

Update src/Directory.Packages.props

3352abc

Co-authored-by: Piotr Kiełkowicz <pkiekowicz@splunk.com>

Update docs/file-based-configuration.md

f894e86

Co-authored-by: Piotr Kiełkowicz <pkiekowicz@splunk.com>

change opamp to development

7cd5894

Merge branch 'main' into opamp-client

ef6585c

# Conflicts: # src/Directory.Packages.props

fix synchronous read

76ab539

RassK requested a review from Copilot April 9, 2026 09:52

Copilot started reviewing on behalf of RassK April 9, 2026 09:52 View session

Copilot AI reviewed Apr 9, 2026

View reviewed changes

Comment thread src/OpenTelemetry.AutoInstrumentation/Configurations/OpAmpSettings.cs Outdated

Comment thread src/OpenTelemetry.AutoInstrumentation/Util/ResourceHelper.cs

RassK added 2 commits April 9, 2026 12:58

fix typo

84d7c02

Merge branch 'main' into opamp-client

af13598

RassK added 3 commits April 9, 2026 16:15

add file based config tests

b0200f8

Merge branch 'opamp-client' of https://github.com/RassK/opentelemetry…

59fcb5e

…-dotnet-instrumentation into opamp-client

remove nullable

e3fd111

Kielek previously requested changes Apr 10, 2026

View reviewed changes

ysolomchenko reviewed Apr 10, 2026

View reviewed changes

RassK added 4 commits April 28, 2026 12:36

update opamp client

64864c6

remove enabled config value

109c898

update attributes

cfb7b99

RassK requested a review from Copilot April 28, 2026 10:49

Copilot started reviewing on behalf of RassK April 28, 2026 10:50 View session

Copilot AI reviewed Apr 28, 2026

View reviewed changes

RassK added 4 commits April 28, 2026 15:29

copilot feedback

b19e021

revert is running change

a0f0aa0

fix naming

298e9be

Merge branch 'main' into opamp-client

0d93eae

Merge branch 'main' into opamp-client

1583462

Conversation

RassK commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Tests

Checklist

Uh oh!

Kielek left a comment

Choose a reason for hiding this comment

Uh oh!

RassK commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ysolomchenko left a comment

Choose a reason for hiding this comment

Uh oh!

RassK commented Sep 30, 2025

Uh oh!

RassK commented Oct 1, 2025

Uh oh!

lachmatt commented Jan 28, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

ysolomchenko commented Apr 9, 2026

Uh oh!

Kielek left a comment

Choose a reason for hiding this comment

Uh oh!

ysolomchenko Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

RassK Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

RassK Apr 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

RassK commented Sep 29, 2025 •

edited

Loading

RassK commented Sep 30, 2025 •

edited

Loading