[METRICS SDK] Validate Base2 Exponential Histogram Aggregation config#4253
Draft
RaviTriv wants to merge 6 commits into
Draft
[METRICS SDK] Validate Base2 Exponential Histogram Aggregation config#4253RaviTriv wants to merge 6 commits into
RaviTriv wants to merge 6 commits into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4253 +/- ##
==========================================
+ Coverage 78.15% 78.17% +0.03%
==========================================
Files 440 440
Lines 18741 18781 +40
==========================================
+ Hits 14645 14681 +36
- Misses 4096 4100 +4
🚀 New features to boost your workflow:
|
e193ae0 to
9c689b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4250
Changes
Validates the Base2 Exponential Histogram Aggregation parameters to align with the OTEL configuration spec.
Naming and Types
Base2ExponentialHistogramAggregationConfig::max_buckets_tomax_size_Base2ExponentialBucketHistogramAggregationConfiguration::max_scaletype toint32DocumentNode::GetSignedIntegerto handle negative valuesValidation
InvalidSchemaExceptionif config value is out of range.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes