[EXPORTER] Fix PrometheusExporter to propagate new options to collector#4055
Open
jaehyeong-cho wants to merge 4 commits intoopen-telemetry:mainfrom
Open
[EXPORTER] Fix PrometheusExporter to propagate new options to collector#4055jaehyeong-cho wants to merge 4 commits intoopen-telemetry:mainfrom
jaehyeong-cho wants to merge 4 commits intoopen-telemetry:mainfrom
Conversation
ed0ccdc to
73496ab
Compare
73496ab to
85676db
Compare
2535da5 to
ff8c097
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4055 +/- ##
==========================================
+ Coverage 82.04% 82.04% +0.01%
==========================================
Files 385 385
Lines 15896 15900 +4
==========================================
+ Hits 13040 13044 +4
Misses 2856 2856
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4052
Changes
Please provide a brief description of the changes here.
I read the comment at #4052 (comment), but understood that the topic of discussion there is more general in scope and has wider impact than this issue. Therefore, this PR aims to focus on fixing the bug described in the issue while maintaining public API backward compatibility (though ABI compatibility may be affected).
PrometheusCollector(with default values for backward compatibility)PrometheusExporterto pass the new options when constructingPrometheusCollectorFor significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes