Skip to content

[CODE HEALTH] Fix clang-tidy performance-for-range-copy warnings #3932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcalff merged 1 commit into from
Mar 13, 2026
+4 −4
Merged

[CODE HEALTH] Fix clang-tidy performance-for-range-copy warnings #3932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions exporters/ostream/include/opentelemetry/exporters/ostream/common_utils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ void print_value(const std::vector<T> &vec, std::ostream &sout)
sout << '[';
size_t i = 1;
size_t sz = vec.size();
for (auto v : vec)
for (const auto &v : vec)
{
sout << v;
if (i != sz)
Expand All @@ -47,7 +47,7 @@ void print_value(const nostd::span<T> &vec, std::ostream &sout)
sout << '[';
size_t i = 1;
size_t sz = vec.size();
for (auto v : vec)
for (const auto &v : vec)
{
sout << v;
if (i != sz)
Expand Down
2 changes: 1 addition & 1 deletion sdk/include/opentelemetry/sdk/common/attributemap_hash.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ inline void GetHash(size_t &seed, const T &arg)
template <class T>
inline void GetHash(size_t &seed, const std::vector<T> &arg)
{
for (auto v : arg)
for (const auto &v : arg)
{
GetHash<T>(seed, v);
}
Expand Down
2 changes: 1 addition & 1 deletion sdk/include/opentelemetry/sdk/instrumentationscope/scope_configurator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ class ScopeConfigurator
return ScopeConfigurator<T>(
[conditions_ = this->conditions_, default_scope_config_ = this->default_scope_config_](
const InstrumentationScope &scope_info) {
for (Condition condition : conditions_)
for (const Condition &condition : conditions_)
{
if (condition.scope_matcher(scope_info))
{
Expand Down
Loading