Skip to content

[CODE HEALTH] Fix clang-tidy performance-unnecessary-value-param warnings#3931

Merged
marcalff merged 9 commits intoopen-telemetry:mainfrom
marcalff:tidy_value_param
Mar 14, 2026
Merged

[CODE HEALTH] Fix clang-tidy performance-unnecessary-value-param warnings#3931
marcalff merged 9 commits intoopen-telemetry:mainfrom
marcalff:tidy_value_param

Conversation

@marcalff
Copy link
Member

@marcalff marcalff commented Mar 12, 2026

Fixes # (issue)

Changes

Please provide a brief description of the changes here.

  • Fixed clang-tidy performance-unnecessary-value-param in the SDK, exporters, and examples.
  • Changing the API requires more analysis, to be done in a different PR.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@codecov
Copy link

codecov bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.07%. Comparing base (4281533) to head (f8a6151).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3931   +/-   ##
=======================================
  Coverage   90.07%   90.07%           
=======================================
  Files         226      226           
  Lines        7226     7226           
=======================================
  Hits         6508     6508           
  Misses        718      718           
Files with missing lines Coverage Δ
...etry/sdk/instrumentationscope/scope_configurator.h 100.00% <100.00%> (ø)
...etry/sdk/metrics/aggregation/default_aggregation.h 79.02% <ø> (ø)
...e/opentelemetry/sdk/metrics/export/metric_filter.h 100.00% <100.00%> (ø)
...telemetry/sdk/metrics/state/async_metric_storage.h 94.45% <100.00%> (ø)
...telemetry/sdk/metrics/state/multi_metric_storage.h 100.00% <100.00%> (ø)
...ntelemetry/sdk/metrics/state/sync_metric_storage.h 88.58% <100.00%> (ø)
...clude/opentelemetry/sdk/metrics/sync_instruments.h 100.00% <100.00%> (ø)
sdk/include/opentelemetry/sdk/metrics/view/view.h 100.00% <ø> (ø)
sdk/include/opentelemetry/sdk/trace/recordable.h 64.29% <100.00%> (ø)
sdk/include/opentelemetry/sdk/trace/span_data.h 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcalff marcalff changed the title [CODE HEALTH] Fix clang-tidy unnecessary value param warnings [CODE HEALTH] Fix clang-tidy performance-unnecessary-value-param warnings Mar 13, 2026
@marcalff marcalff marked this pull request as ready for review March 13, 2026 21:20
@marcalff marcalff requested a review from a team as a code owner March 13, 2026 21:20
Copy link
Member

@dbarker dbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@marcalff marcalff merged commit 86e5c6d into open-telemetry:main Mar 14, 2026
114 of 115 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants