[EXPORTERS] Configure prometheus timestamps#3894
Open
carlosroman wants to merge 4 commits intoopen-telemetry:mainfrom
Open
[EXPORTERS] Configure prometheus timestamps#3894carlosroman wants to merge 4 commits intoopen-telemetry:mainfrom
carlosroman wants to merge 4 commits intoopen-telemetry:mainfrom
Conversation
carlosroman
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3894 +/- ##
=======================================
Coverage 90.06% 90.06%
=======================================
Files 226 226
Lines 7223 7223
=======================================
Hits 6505 6505
Misses 718 718 🚀 New features to boost your workflow:
|
Member
|
@carlosroman - there are merge conflicts to be resolved in this PR. |
lalitb
reviewed
Mar 9, 2026
|
|
||
| inline bool GetPrometheusWithoutTimestamps() | ||
| { | ||
| constexpr char kPrometheusWithoutTypeSuffix[] = "OTEL_CPP_PROMETHEUS_EXPORTER_WITHOUT_TIMESTAMPS"; |
Member
There was a problem hiding this comment.
nit - The variable is named kPrometheusWithoutTypeSuffix but holds the timestamps env var. Should be kPrometheusWithoutTimestamps?
lalitb
reviewed
Mar 9, 2026
carlosroman
force-pushed
the
configure-prometheus-timestamps
branch
from
5799702 to
f7b4b42
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2316 and #3484.
Changes
This PR adds the ability to configure Prometheus timestamps. It was originally removed in #2316 but #2213 added it back in. I have another PR (#3895) that actually removes explicit timestamps from metric points instead if you'd prefer that one over this one. The reason I created this one is that it has been like this for 3 years so maybe people rely on this behavior.
CHANGELOG.mdupdated for non-trivial changes