Skip to content

fix: Remove remaining default configuration.#14351

Merged
mx-psi merged 15 commits intoopen-telemetry:mainfrom
tank-500m:fix-otlp-default-balancer
Jan 26, 2026
Merged

fix: Remove remaining default configuration.#14351
mx-psi merged 15 commits intoopen-telemetry:mainfrom
tank-500m:fix-otlp-default-balancer

Conversation

@tank-500m
Copy link
Copy Markdown
Contributor

Description

Removed the remaining default configuration.
OTLP exporter’s default load balancing is intended to be round_robin.

Link to tracking issue

Fixes #
#14090

Testing

Documentation

@tank-500m tank-500m requested a review from a team as a code owner January 5, 2026 10:10
@tank-500m tank-500m requested a review from dmitryax January 5, 2026 10:10
@dmitryax
Copy link
Copy Markdown
Member

dmitryax commented Jan 6, 2026

Please document this change better with all side effects and add a changelog item

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jan 7, 2026

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

✅ 61 untouched benchmarks
⏩ 20 skipped benchmarks1


Comparing tank-500m:fix-otlp-default-balancer (2a325cf) with main (55399d4)

Open in CodSpeed

Footnotes

  1. 20 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@bogdandrutu bogdandrutu enabled auto-merge January 8, 2026 20:25
auto-merge was automatically disabled January 9, 2026 03:01

Head branch was pushed to by a user without write access

@tank-500m
Copy link
Copy Markdown
Contributor Author

fix missing test...

@dmathieu dmathieu added the ready-to-merge Code review completed; ready to merge by maintainers label Jan 9, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.82%. Comparing base (55399d4) to head (2a325cf).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14351      +/-   ##
==========================================
- Coverage   91.85%   91.82%   -0.03%     
==========================================
  Files         677      677              
  Lines       42680    42679       -1     
==========================================
- Hits        39203    39190      -13     
- Misses       2423     2431       +8     
- Partials     1054     1058       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mx-psi mx-psi enabled auto-merge January 9, 2026 11:10
auto-merge was automatically disabled January 9, 2026 15:05

Head branch was pushed to by a user without write access

@tank-500m
Copy link
Copy Markdown
Contributor Author

How should I fix contrib-test?

@evan-bradley
Copy link
Copy Markdown
Contributor

@tank-500m Would you be willing to create a follow-up PR to fix the errors? We will likely merge this PR first, update the version of the core libraries used in contrib, then update the expected error message in the failing tests.

@tank-500m
Copy link
Copy Markdown
Contributor Author

@evan-bradley
yes I’ll give it a try

@tank-500m
Copy link
Copy Markdown
Contributor Author

@evan-bradley yes I’ll give it a try

It seems to be fixed now.

@mx-psi mx-psi added this pull request to the merge queue Jan 26, 2026
Merged via the queue into open-telemetry:main with commit c4695a7 Jan 26, 2026
61 checks passed
@otelbot
Copy link
Copy Markdown
Contributor

otelbot Bot commented Jan 26, 2026

Thank you for your contribution @tank-500m! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

exporter/otlp ready-to-merge Code review completed; ready to merge by maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants