otelcol/internal/grpclog: suppress benign gRPC HandleStreams disconnect warning#14325
Closed
rishabhvenu wants to merge 1 commit intoopen-telemetry:mainfrom
Closed
otelcol/internal/grpclog: suppress benign gRPC HandleStreams disconnect warning#14325rishabhvenu wants to merge 1 commit intoopen-telemetry:mainfrom
rishabhvenu wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
|
|
…ct warning Filter out the "HandleStreams failed to read frame" warning that occurs when clients disconnect abruptly. This warning provides no actionable information and creates log noise. Fixes open-telemetry#5169
rishabhvenu
force-pushed
the
fix/grpc-handlestreams-warning-filter
branch
from
f8bf9bd to
3cb1aa9
Compare
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Contributor
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5169
What:
Suppress the gRPC transport warning "HandleStreams failed to read frame" that happens on abrupt client disconnects.
Why:
This warning is frequent and non-actionable log noise; the disconnect is handled normally by gRPC.
How:
Wrap the gRPC zap logger core with a small filter (
filterCore) that drops only log entries whose message contains "HandleStreams failed to read frame". All other logs pass through unchanged.Testing:
makego test ./otelcol/internal/grpclog -run TestFilterHandleStreamsWarning -vgo test ./receiver/otlpreceiver -run TestReproduceIssue5169 -vExample log line that is now filtered: