[chore][pkg/kafka/configkafka] resolve_canonical_bootstrap_servers_only is ignored for franz-go

[carsonip]

Description

Update docs and comment to state that franz-go does not support resolve_canonical_bootstrap_servers_only

Link to tracking issue

Testing

Documentation

[paulojmdias]

@carsonip Thanks for your PR.

Sarama was completely removed from those packages, if this parameter is unused in franz-go, we should completely remove it. WDYT ?

I could also check what is needed for franz-go support it

[carsonip]

Sarama was completely removed from those packages

Thanks for pointing that out. I was not aware. Then we'll need to follow the deprecation process to clear out sarama-specific config. But in this resolve_canonical_bootstrap_servers_only case, if we manage to either contribute to franz-go or build this into configkafka, a deprecation won't be needed. Let me put this PR into draft and think about it.

[axw]

Looks like franz-go doesn't directly support this, but enables it by allowing you to inject a Dialer. Relevant KIPs:

• https://cwiki.apache.org/confluence/display/KAFKA/KIP-302+-+Enable+Kafka+clients+to+use+all+DNS+resolved+IP+addresses
• https://cwiki.apache.org/confluence/display/KAFKA/KIP-235%3A+Add+DNS+alias+support+for+secured+connection

OTOH nobody has raised any fuss about the config not working since we switched to franz-go... 🤷‍♂️

Maybe we deprecated and remove resolve_canonical_bootstrap_servers_only, and on request we could add client_dns_lookup, like client.dns.lookup specified in the KIPs?

[paulojmdias]

Maybe we deprecated and remove resolve_canonical_bootstrap_servers_only, and on request we could add client_dns_lookup, like client.dns.lookup specified in the KIPs?

I'm ok with this approach. I think it is better to support client.dns.lookup with their supported values instead of supporting only the resolve_canonical_bootstrap_servers_only.

[github-actions]

This PR was marked stale due to lack of activity. It will be closed in 14 days.

[github-actions]

Closed as inactive. Feel free to reopen if this PR is still being worked on.