[chore][receiver/sqlserverreceiver] Fix flaky sqlserverreceiver integration tests#45317
Merged
songy23 merged 4 commits intoopen-telemetry:mainfrom Jan 12, 2026
Conversation
The SQL Server integration tests are flaky when running in CI. The reason for this is twofold: first, the LookbackTime is set to 1μs while the collection interval is 1ms. This causes issues where the lookback time window is too small to find any queries that ran. Second, the test was setting a variable inside an EventuallyWithT closure and then using that variable outside the closure, which meant the final assertion could fail even when EventuallyWithT succeeded. The fix increases LookbackTime to 1 second and moves all validation logic inside the EventuallyWithT closure to ensure atomicity.
github-actions
Bot
added
receiver/sqlserver
Run Windows
dehaansa
approved these changes
Jan 9, 2026
Contributor
dehaansa
left a comment
dehaansa
left a comment
There was a problem hiding this comment.
One nit, otherwise LGTM.
| assert.True(tt, found, "Expected query not found in logs") | ||
| }, 10*time.Second, 100*time.Millisecond) | ||
|
|
||
| assert.True(t, found, "Expected query not found in final validation") |
Contributor
There was a problem hiding this comment.
This shouldn't be necessary, as the Eventually will fail if the last attempt fails and this won't be reached.
Contributor
Author
There was a problem hiding this comment.
Good spot, I have removed this assert.
crobert-1
reviewed
Jan 9, 2026
crobert-1
approved these changes
Jan 12, 2026
crobert-1
added
the
ready to merge
Contributor
|
Thank you for your contribution @osullivandonal! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. If you are getting started contributing, you can also join the CNCF Slack channel #opentelemetry-new-contributors to ask for guidance and get help. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The SQL Server integration tests are flaky when running in CI.
The reason for this is twofold: first, the LookbackTime is set to 1μs while the collection interval is 1ms. This causes issues where the lookback time window is too small to find any queries that ran. Second, the test was setting a variable inside an EventuallyWithT closure and then using that variable outside the closure, which meant the final assertion could fail even when EventuallyWithT succeeded.
The fix increases LookbackTime to 1 second and moves all validation logic inside the EventuallyWithT closure to ensure atomicity.
Link to tracking issue
Fixes #45070
Testing
Test was ran locally multiple times with no failures: