-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[chore] [connector/spanmetrics] Better docs on high cardinality handling #45283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[chore] [connector/spanmetrics] Better docs on high cardinality handling #45283
Conversation
| The span metrics connector provides an optional circuit breaker through the `aggregation_cardinality_limit` attribute (disabled by default) to mitigate cardinality explosion. While this feature addresses performance and cost concerns, it does not resolve the underlying issue of semantically meaningless operation names. | ||
| **Fixing high cardinality span name issues** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved it below with 2 sections:
- Addressing high cardinality span names in the ingestion pipeline
- Addressing high cardinality span names in the instrumentation code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That let's the following paragraphs without making sense, I think
| # ... | ||
| ``` | ||
|
|
||
| **Addressing high cardinality span names in the instrumentation code** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't feel this documentations should be added here but in a more general OpenTelemetry documentation like the website or something. We can point that documentation from here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do agree it would be better.
I couldn't find a good home for such docs:
- The Span Metrics Connector docs are this github page, see https://opentelemetry.io/docs/collector/components/connector/
- The languages section here may be the right top level section but we would probably want to create a subsection with instrumentation best practices.
I hope the OTel Blueprint initiative will create documentation that would be a great home for such content.
Do you have suggestions?
My mental model was to follow the mantra "Don't let perfection stand in the way of progress" and to start here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should go to https://github.com/open-telemetry/opentelemetry.io and create an issue there.
Description
Better docs on high cardinality handling: explain how to modify instrumentation code to keep low cardinality and compliant span nmes while providing the desired context.
Link to tracking issue
Fixes
Testing
Documentation