[extension/text_encoding] Pass separators from config to codec#45272
Merged
atoulme merged 1 commit intoopen-telemetry:mainfrom Jan 10, 2026
Merged
Conversation
jon-signal
requested review from
a team,
MovieStoreGuy and
atoulme
as code owners
|
|
Contributor
|
Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib. Important reminders:
A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better! |
atoulme
pushed a commit
that referenced
this pull request
Jan 7, 2026
…d of lines (#45274) As a companion to #45272, this partially fixes #42797 by avoiding spurious newlines between blocks of log records. This change modifies existing unit tests to demonstrate the new behavior. Since tests already existed for this behavior, I recognize that the existing behavior may already be working as intended. Even so, I offer this in the spirit of fully addressing the concerns raise in #42797.
jon-signal
force-pushed
the
text_encoding_separator_config
branch
from
dd12ecb to
4eaf343
Compare
atoulme
approved these changes
Jan 10, 2026
Contributor
|
Thank you for your contribution @jon-signal! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. If you are getting started contributing, you can also join the CNCF Slack channel #opentelemetry-new-contributors to ask for guidance and get help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This (partially) fixes #42797 by passing marshalling/unmarshalling separators from the text_encoding extension configuration to the
textLogCodec. After this change, configured separators should work as expected. This change includes a new unit test to show that separators configuration is propagated as expected.This pull request does not address the second part of of #42797 related to spurious line breaks because I think there's room for reasonable minds to disagree on a solution there. I'll open a separate pull request for that with the expectation that it may warrant more discussion.