build: enable type-aware linting and fix turbo dependencies#112
Merged
overbalance merged 1 commit intoopen-telemetry:mainfrom Jan 16, 2026
Merged
Conversation
overbalance
force-pushed
the
overbalance/minor-housekeeping
branch
from
99567fa to
de4d3e4
Compare
| "@opentelemetry/api-logs": "*", | ||
| "@opentelemetry/instrumentation": "*", | ||
| "@opentelemetry/web-utils": "*" | ||
| "@opentelemetry/api-logs": "0.209.0", |
Contributor
There was a problem hiding this comment.
This change is so each instrumentation can use its own version of the api right?
Contributor
Author
There was a problem hiding this comment.
Not necessarily. It's to ensure the "latest" version isn't blindly installed. Ideally all packages use the same dependency versions.
Contributor
Author
There was a problem hiding this comment.
I am going to revert back to * and we can discuss offline.
| export default [ | ||
| { | ||
| files: ['packages/*/src/**/*.{js,ts,mjs}'], | ||
| ignores: ['**/*.test.ts', '**/*.spec.ts'], |
Contributor
There was a problem hiding this comment.
Do we want to ignore test files?
Contributor
Author
There was a problem hiding this comment.
Yes. The two eslint plugins are for source code only.
overbalance
force-pushed
the
overbalance/minor-housekeeping
branch
from
7e5e791 to
30eb233
Compare
overbalance
force-pushed
the
overbalance/minor-housekeeping
branch
from
30eb233 to
f7726d8
Compare
joaquin-diaz
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Type-aware ESLint rules were not enabled, preventing detection of instance method usage issues. Additionally, turbo had an incorrect dependency.
Short description of the changes
projectServicefor source files (excluding tests)check-typestask to depend on^buildinstead of^check-typesType of change
How Has This Been Tested?