Add ProxyConnectionSettings to all connection types#221
Merged
andykellr merged 4 commits intoopen-telemetry:mainfrom Aug 26, 2025
Merged
Conversation
michel-laterman
force-pushed
the
feat/proxy-connection-settings
branch
from
f76d025 to
203dded
Compare
andykellr
reviewed
May 8, 2025
andykellr
reviewed
May 8, 2025
Member
|
Sorry for the delay, I had the comments in Pending state, forgot to publish them 🤦 |
tigrannajaryan
approved these changes
Aug 20, 2025
Member
tigrannajaryan
left a comment
tigrannajaryan
left a comment
There was a problem hiding this comment.
Prototype done in open-telemetry/opamp-go#389
LGTM.
Contributor
Author
|
@andykellr @tigrannajaryan, can we get this merged and a new release tagged please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new
ProxyConnectionSettingsmessage to all connection types.WIP Demo: open-telemetry/opamp-go#389