Skip to content

Change stack depth limit to 256#1657

Open
baylesj wants to merge 2 commits intomasterfrom
stack-depth
Open

Change stack depth limit to 256#1657
baylesj wants to merge 2 commits intomasterfrom
stack-depth

Conversation

@baylesj
Copy link
Contributor

@baylesj baylesj commented Mar 15, 2026

1000 as a limit results in fuzzer crashes due to blowing up the stack, it's just too deep for a lot of machine configurations and is not a reasonable default.

This patch lowers the default to 256, which is still quite high, but is a more reasonable default. The value is still overridable for projects that need more depth for any reason.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 23104539686

Details

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.937%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib_json/json_reader.cpp 2 3 66.67%
Totals Coverage Status
Change from base Build 22881405816: 0.0%
Covered Lines: 2551
Relevant Lines: 2676

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants