Lyrical compatibility#163
Open
mxgrey wants to merge 2 commits into
Open
Conversation
Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai>
5 tasks
| // TODO(luca) this could be a component instead of a hash map | ||
| _initial_aabbs[entity] = aabb->Data(); | ||
| _initial_poses[entity] = pose->Data(); | ||
| enableComponent<components::AxisAlignedBox>(ecm, entity, false); |
Member
There was a problem hiding this comment.
This was added because of the comment above (RTF dropping as soon as lift starts moving).
Does this still happen? If it does we should still remove the components but not inside the Each call (i.e. we collect them into a vector then iterate and remove outside the loop).
If it doesn't happen anymore we should just remove the optimization comment above since it's not relevant anymore
Collaborator
Author
There was a problem hiding this comment.
Thanks for calling this out, I wasn't aware of the reason the component was being removed.
I haven't looked at whether there's a frame drop, but if it's a possible concern then I don't mind collecting the entities and removing the component after the Each.
Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes a line that was causing an undefined behavior segfault in gz_sim.
The stack trace of the crash can be seen here. It seems that removing the component from the entity inside the Each callback was somehow invalidating the iterators that
Eachwas relying on.