Fix #4: use-after-free of embeddedAddr in rs4_embed_cmsk()#6
Open
runlevel5 wants to merge 1 commit into
Open
Conversation
embeddedAddr was derived from *io_rs4 before realloc() may relocate the buffer, then dereferenced by memmove()/memcpy() afterwards. GCC reports this as -Werror=use-after-free (e.g. Fedora 39 / Ubuntu 26.04), failing the build, and it is a genuine latent bug regardless of the warning. Move the embeddedAddr computation to after the realloc() so it is derived from the (possibly new) *io_rs4 pointer.
Author
|
@rarbab wondering if you could tag the right reviewers for this PR. Many thanks |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
embeddedAddrwas derived from*io_rs4beforerealloc()may relocate the buffer, then dereferenced bymemmove()/memcpy()afterwards. GCC reports this as-Werror=use-after-free(e.g. Fedora 39 / Ubuntu 26.04), failing the build, and it is a genuine latent bug regardless of the warning.Move the
embeddedAddrcomputation to after therealloc()so it is derived from the (possibly new)*io_rs4pointer.