Skip to content

Fixes 30486: Map SchemaSearch to the Playwright ingestion lane#30487

Merged
harshach merged 1 commit into
mainfrom
harshach/fix-plan-playwright-tests
Jul 25, 2026
Merged

Fixes 30486: Map SchemaSearch to the Playwright ingestion lane#30487
harshach merged 1 commit into
mainfrom
harshach/fix-plan-playwright-tests

Conversation

@harshach

@harshach harshach commented Jul 25, 2026

Copy link
Copy Markdown
Collaborator

Describe your changes:

Fixes #30486

Adds the Ingestion project to the Explore impact mapping so the ingestion-tagged SchemaSearch.spec.ts selector has a runnable lane instead of aborting targeted Playwright planning. Adds a regression test that runs PR selection for an Explore source change and verifies SchemaSearch.spec.ts is scheduled under Ingestion.

Type of change:

  • Bug fix

High-level design:

N/A — small change.

Tests:

Use cases covered

  • Explore source changes produce a valid targeted Playwright plan for SchemaSearch.spec.ts.

Unit tests

  • Added coverage in .github/scripts/tests/test_playwright_ci_planning.py.
  • uv run --with pytest pytest .github/scripts/tests/test_playwright_ci_planning.py — 54 passed.

Backend integration tests

  • Not applicable; no backend API changes.

Ingestion integration tests

  • Not applicable; no ingestion implementation changes.

Playwright (UI) tests

  • Not applicable; this changes CI planning only.

Manual testing performed

UI screen recording / screenshots:

Not applicable; no UI changes.

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>.
  • My PR is linked to a GitHub issue via Fixes #<issue-number> above.
  • I have added tests and listed them above.
  • I have added a test that covers the exact scenario being fixed.

Greptile Summary

Updates Playwright CI planning for Explore changes.

  • Adds the Ingestion project to the Explore impact mapping.
  • Adds regression coverage confirming SchemaSearch.spec.ts is selected for the ingestion lane.

Confidence Score: 5/5

The PR appears safe to merge with no actionable defects identified.

The updated impact mapping makes the ingestion-tagged SchemaSearch test reachable in targeted planning, while downstream Playwright discovery filters project-incompatible tests; the regression test covers the intended selection.

Important Files Changed

Filename Overview
.github/playwright/impact-map.json Adds the existing Ingestion project to the Explore mapping so ingestion-tagged search tests have a compatible targeted lane.
.github/scripts/tests/test_playwright_ci_planning.py Adds focused regression coverage for selecting SchemaSearch under Ingestion after an Explore source change.

Reviews (1): Last reviewed commit: "fix(playwright): map schema search to in..." | Re-trigger Greptile

@github-actions github-actions Bot added backend safe to test Add this label to run secure Github workflows on PRs labels Jul 25, 2026
@gitar-bot

gitar-bot Bot commented Jul 25, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Maps SchemaSearch to the Playwright ingestion lane in Explore impact mapping and adds regression test coverage for PR selection. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@harshach
harshach marked this pull request as ready for review July 25, 2026 04:00
@harshach
harshach requested a review from akash-jain-10 as a code owner July 25, 2026 04:00
Copilot AI review requested due to automatic review settings July 25, 2026 04:00
@harshach
harshach requested review from a team and tutte as code owners July 25, 2026 04:00
@github-actions

Copy link
Copy Markdown
Contributor

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

@harshach harshach added the skip-pr-checks Bypass PR metadata validation check label Jul 25, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes targeted Playwright planning for Explore-related changes by ensuring the impact mapping includes the Ingestion Playwright project, so SchemaSearch.spec.ts (which runs under Ingestion) is considered runnable and shard planning no longer aborts.

Changes:

  • Add Ingestion to the Explore impact-map project list so *Search* specs (including SchemaSearch.spec.ts) match at least one runnable project.
  • Add a regression test asserting that an Explore component change schedules SchemaSearch.spec.ts with the Ingestion project.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/playwright/impact-map.json Extends the Explore impact mapping to include Ingestion, preventing “matched no runnable tests” failures for ingestion-tagged search specs.
.github/scripts/tests/test_playwright_ci_planning.py Adds a regression test that validates SchemaSearch.spec.ts is scheduled under Ingestion when Explore sources change.

@github-actions

Copy link
Copy Markdown
Contributor

✅ Playwright Results — workflow succeeded

Validated commit 5642e7b693a44d8d98ed24f96fbe0023db470165 in Playwright run 30143268960, attempt 1.

✅ 537 passed · ❌ 0 failed · 🟡 0 flaky · ⏭️ 5 skipped · 🧰 0 lifecycle flaky

Performance

Blocking targets: ✅ met · Optimization targets: 🟡 in progress

Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting.

🕒 Full workflow signal wall (to summary) 51m 20s

⏱️ Max setup 3m 41s · max shard execution 18m 15s · max shard-job elapsed before upload 21m 32s · reporting 4s

🌐 202.43 requests/attempt · 2.86 app boots/UI scenario · 22.83% common-shard skew

Optimization targets still in progress:

  • Common shard skew was 22.83% (convergence target: at most 15%).
  • Browser traffic was 202.43 requests per attempt (convergence target: fewer than 200).
  • Application boot ratio was 2.86 per UI scenario (1596 boots / 558 scenarios; convergence target: at most 1).
Shard Passed Failed Flaky Skipped Lifecycle failed Lifecycle flaky
✅ Shard chromium-01 143 0 0 3 0 0
✅ Shard chromium-02 133 0 0 0 0 0
✅ Shard chromium-03 123 0 0 0 0 0
✅ Shard data-asset-rules-01 61 0 0 0 0 0
✅ Shard domain-isolation-01 14 0 0 0 0 0
✅ Shard global-state-01 23 0 0 0 0 0
✅ Shard ingestion-01 1 0 0 0 0 0
✅ Shard reindex-01 2 0 0 0 0 0
✅ Shard search-01 10 0 0 0 0 0
✅ Shard search-rbac-01 27 0 0 2 0 0

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@harshach
harshach merged commit 39c321b into main Jul 25, 2026
187 of 188 checks passed
@harshach
harshach deleted the harshach/fix-plan-playwright-tests branch July 25, 2026 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend safe to test Add this label to run secure Github workflows on PRs skip-pr-checks Bypass PR metadata validation check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Playwright planner mapping for SchemaSearch

3 participants