Fixes 30486: Map SchemaSearch to the Playwright ingestion lane#30487
Conversation
Code Review ✅ ApprovedMaps SchemaSearch to the Playwright ingestion lane in Explore impact mapping and adds regression test coverage for PR selection. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
❌ PR checklist incompleteThis PR cannot be merged until the following are addressed on its linked issue:
The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically. Maintainers can bypass this check by adding the |
There was a problem hiding this comment.
Pull request overview
This PR fixes targeted Playwright planning for Explore-related changes by ensuring the impact mapping includes the Ingestion Playwright project, so SchemaSearch.spec.ts (which runs under Ingestion) is considered runnable and shard planning no longer aborts.
Changes:
- Add
Ingestionto the Explore impact-map project list so*Search*specs (includingSchemaSearch.spec.ts) match at least one runnable project. - Add a regression test asserting that an Explore component change schedules
SchemaSearch.spec.tswith theIngestionproject.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/playwright/impact-map.json |
Extends the Explore impact mapping to include Ingestion, preventing “matched no runnable tests” failures for ingestion-tagged search specs. |
.github/scripts/tests/test_playwright_ci_planning.py |
Adds a regression test that validates SchemaSearch.spec.ts is scheduled under Ingestion when Explore sources change. |
✅ Playwright Results — workflow succeededValidated commit ✅ 537 passed · ❌ 0 failed · 🟡 0 flaky · ⏭️ 5 skipped · 🧰 0 lifecycle flaky PerformanceBlocking targets: ✅ met · Optimization targets: 🟡 in progress Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting. 🕒 Full workflow signal wall (to summary) 51m 20s ⏱️ Max setup 3m 41s · max shard execution 18m 15s · max shard-job elapsed before upload 21m 32s · reporting 4s 🌐 202.43 requests/attempt · 2.86 app boots/UI scenario · 22.83% common-shard skew Optimization targets still in progress:
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
Describe your changes:
Fixes #30486
Adds the
Ingestionproject to the Explore impact mapping so the ingestion-taggedSchemaSearch.spec.tsselector has a runnable lane instead of aborting targeted Playwright planning. Adds a regression test that runs PR selection for an Explore source change and verifiesSchemaSearch.spec.tsis scheduled underIngestion.Type of change:
High-level design:
N/A — small change.
Tests:
Use cases covered
SchemaSearch.spec.ts.Unit tests
.github/scripts/tests/test_playwright_ci_planning.py.uv run --with pytest pytest .github/scripts/tests/test_playwright_ci_planning.py— 54 passed.Backend integration tests
Ingestion integration tests
Playwright (UI) tests
Manual testing performed
Ingestionproject.UI screen recording / screenshots:
Not applicable; no UI changes.
Checklist:
Fixes <issue-number>: <short explanation>.Fixes #<issue-number>above.Greptile Summary
Updates Playwright CI planning for Explore changes.
Ingestionproject to the Explore impact mapping.SchemaSearch.spec.tsis selected for the ingestion lane.Confidence Score: 5/5
The PR appears safe to merge with no actionable defects identified.
The updated impact mapping makes the ingestion-tagged SchemaSearch test reachable in targeted planning, while downstream Playwright discovery filters project-incompatible tests; the regression test covers the intended selection.
Important Files Changed
Reviews (1): Last reviewed commit: "fix(playwright): map schema search to in..." | Re-trigger Greptile