Unskip the bulk import playwright test#30458
Conversation
❌ PR checklist incompleteThis PR cannot be merged until the following are addressed on its linked issue:
The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically. Maintainers can bypass this check by adding the |
🔴 Playwright Results — workflow failedValidated commit ✅ 0 passed · ❌ 0 failed · 🟡 0 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky Pipeline and setup failures (2)
PerformanceBlocking targets: ❌ unmet · Optimization targets: 🟡 in progress Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting. 🕒 Full workflow signal wall (to summary) 1h 4m 49s ⏱️ Max setup 1m 23s · max shard execution 20m 2s · max shard-job elapsed before upload 23m 25s · reporting 5s 🌐 162.50 requests/attempt · 1.30 app boots/UI scenario · 0.00% common-shard skew Optimization targets still in progress:
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
Code Review ✅ ApprovedUnskips the bulk import Playwright E2E test to re-enable coverage for the feature. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
Describe your changes:
Fixes #
I worked on ... because ...
Type of change:
High-level design:
N/A — small change.
Tests:
Use cases covered
Unit tests
Backend integration tests
Ingestion integration tests
Playwright (UI) tests
Manual testing performed
UI screen recording / screenshots:
Not applicable.
Checklist:
Fixes <issue-number>: <short explanation>Fixes #<issue-number>above.Summary by Gitar
BulkImport.spec.tseditTaskCommentto sendapplication/jsoncontent type to prevent 415 errorsThis will update automatically on new commits.
Greptile Summary
The PR enables the existing Bulk Import Export Playwright suite by replacing
test.describe.fixmewithtest.describe.Confidence Score: 4/5
The PR is not yet safe to merge because each newly enabled suite run permanently leaks its shared catalog fixtures.
The enabled suite creates six persistent entities in beforeAll without suite-level teardown, so repeated executions accumulate catalog and search state even after the previously reported table cleanup is added.
openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/BulkImport.spec.ts
Important Files Changed
Reviews (2): Last reviewed commit: "Merge branch 'main' into unskip-bulk-imp..." | Re-trigger Greptile