test(ui): re-enable Domains, Data Product & domain-rename E2E suites

[siddhant1]

What & why

Re-enables Playwright E2E coverage that had been switched off — mostly by the bulk-skip in #29909 ("Skip failing main specs") plus a few one-off skips. When actually run against a current build, the vast majority already pass; this PR fixes the handful that had genuinely broken (all from UI-component migrations) and re-enables everything that is green.

Re-enabled + fixed

Suite	Result	Fix
Domains (9 describe suites)	49/49 green	47 already passed once run. Fixed the 2 real failures — both selector drift: "Add Assets" migrated to the core-ui asset-selection-modal Dialog (old form-heading testid gone); tree toggle is now a radio, not a button.
DomainDataProductsWidgets	6/6 green	Marked test.describe.serial — the suite is one sequential scenario (assign widgets → add assets → verify → remove); parallel execution violated that ordering. Also fixed the data-product asset-removal count-timing bug: wait for the asset card to render before counting (count() doesn't auto-wait, so it read 0 and removed nothing).
GlossaryNavigation empty-state	green	Asserted the empty-glossary placeholder (message.no-glossary-term) instead of the "No Glossary Term found" row — that row only appears when a status filter matches nothing, not for a 0-term glossary.
Glossary "Request description task", EntityRenameConsolidation domain rename ×2	green	Passed as-is; just unskipped.

Left skipped (blocked on product/BE work — documented in-code)

• DataMarketplace ×3 — navigate to /data-marketplace/* sub-routes removed in refactor(ui): render Data Marketplace home page on the main app layout #27377.
• GlossaryStatusFilterNestedTerms ×5 — assert flat nested-term results on a status filter. Not a regression: created already-skipped in fix glossary status frontend filtering logic to move to backend #25428. The status-filter-only path fetches via directChildrenOf (root level); flat nested results would need the frontend to route status-only queries through the flat search API (which the search path already uses).
• Glossary "Term should stay approved when changes made by reviewer" — async governance workflow reverts the reviewer's status change (BE).

BulkImport is intentionally untouched.

Testing

All re-enabled tests verified green locally against a running stack (localhost:8585): Domains 49/49, DomainDataProductsWidgets 6/6, GlossaryNavigation empty-state, Glossary request-description-task, EntityRenameConsolidation domain-rename ×2.

🤖 Generated with Claude Code

Greptile Summary

Re-enables and updates previously skipped Playwright coverage.

• Re-enables domain, domain-rename, glossary, and landing-page widget E2E suites.
• Updates selectors for migrated domain and glossary UI states.
• Serializes the state-dependent domain/data-product widget scenario and revises asset cleanup synchronization.

Confidence Score: 5/5

The PR appears safe to merge because no eligible blocking failures remain.

No blocking failure remains within the scope of this follow-up review.

Important Files Changed

Filename	Overview
openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/EntityRenameConsolidation.spec.ts	Re-enables two domain rename consolidation scenarios.
openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/Glossary/GlossaryNavigation.spec.ts	Re-enables the empty-glossary scenario and updates its placeholder assertion.
openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/LandingPageWidgets/DomainDataProductsWidgets.spec.ts	Re-enables the stateful widget suite in serial mode and synchronizes data-product asset removal with card rendering.
openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Domains.spec.ts	Re-enables domain suites and updates selectors for the asset modal and tree-view control.
openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Glossary.spec.ts	Re-enables the glossary-term description-task scenario.

_{Reviews (3): Last reviewed commit: "Merge branch 'main' into sid/reenable-do..." | Re-trigger Greptile}

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[github-actions]

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

• No GitHub issue is linked. Link an issue in the Development section of the PR (or add Fixes #12345 to the description). For a same-org cross-repo issue, add Fixes open-metadata/<repo>#123 to the description.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

[github-actions]

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

[github-actions]

🔴 Playwright Results — 1 test failure(s)

✅ 112 passed · ❌ 1 failed · 🟡 5 flaky · ⏭️ 1 skipped

Shard	Passed	Failed	Flaky	Skipped
🔴 Shard 1	112	1	5	1

Genuine Failures (failed on all attempts)

❌ Features/Glossary/GlossaryNavigation.spec.ts › should show empty state when glossary has no terms (shard 1)

Error: �[2mexpect(�[22m�[31mlocator�[39m�[2m).�[22mtoBeVisible�[2m(�[22m�[2m)�[22m failed

Locator: getByText(/there are no Glossary Terms defined/i)
Expected: visible
Timeout: 15000ms
Error: element(s) not found

Call log:
�[2m  - Expect "toBeVisible" with timeout 15000ms�[22m
�[2m  - waiting for getByText(/there are no Glossary Terms defined/i)�[22m

🟡 5 flaky test(s) (passed on retry)

• Pages/Glossary.spec.ts › Glossary & terms creation for reviewer as user (shard 1, 1 retry)
• Pages/Glossary.spec.ts › Approve and reject glossary term from Glossary Listing (shard 1, 1 retry)
• Pages/Glossary.spec.ts › Rename Glossary Term and verify assets (shard 1, 1 retry)
• Pages/Glossary.spec.ts › Request description task for Glossary Term (shard 1, 2 retries)
• Pages/Glossary.spec.ts › Column selection and visibility for Glossary Terms table (shard 1, 1 retry)

📦 Download artifacts

How to debug locally

# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[siddhant1]

Superseded by #30451 — re-opened from a branch on open-metadata/OpenMetadata (this PR's head lived on a fork) so the Playwright E2E CI runs with full repository access. Continuing there.

[gitar-bot]

Code Review 👍 Approved with suggestions 1 resolved / 2 findings

Re-enables previously skipped Playwright E2E suites for Domains, Data Products, and domain renames with updated component selectors and serial execution. Consider replacing the waitFor() call with a visible assertion for the drawer.

💡 Quality: Use a visible assertion instead of waitFor() for the drawer

📄 openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Domains.spec.ts:3747

page.getByTestId('add-domain-form').waitFor() waits for attachment only and provides no explicit assertion; the repo's Playwright guidance prefers visible assertions over waitForSelector-style waits. Replace with await expect(page.getByTestId('add-domain-form')).toBeVisible(); so the drawer's readiness is asserted before interacting with the description editor.

Assert the drawer form is visible rather than merely waiting for it.

await page.getByTestId('add-domain').click();
await expect(page.getByTestId('add-domain-form')).toBeVisible();

✅ 1 resolved

✅ Quality: New describe block leaks created table entity (no afterAll)

📄 openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Domains.spec.ts:3721-3728
The new Domain description editor popups suite creates a table (and its backing database service) in beforeAll via table.create(apiContext) but never deletes it. table.delete deletes the database service recursively, and other suites in this file clean up their entities. Without an afterAll calling table.delete(apiContext), this suite leaks test data on every run. Add an afterAll that performs admin login and calls await table.delete(apiContext).

🤖 Prompt for agents

Code Review: Re-enables previously skipped Playwright E2E suites for Domains, Data Products, and domain renames with updated component selectors and serial execution. Consider replacing the waitFor() call with a visible assertion for the drawer.

1. 💡 Quality: Use a visible assertion instead of waitFor() for the drawer
   Files: openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Domains.spec.ts:3747

   `page.getByTestId('add-domain-form').waitFor()` waits for attachment only and provides no explicit assertion; the repo's Playwright guidance prefers visible assertions over waitForSelector-style waits. Replace with `await expect(page.getByTestId('add-domain-form')).toBeVisible();` so the drawer's readiness is asserted before interacting with the description editor.

   Fix (Assert the drawer form is visible rather than merely waiting for it.):
   await page.getByTestId('add-domain').click();
   await expect(page.getByTestId('add-domain-form')).toBeVisible();

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact

gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Gitar}