Fixed context center memories flaky tests#30437
Conversation
❌ PR checklist incompleteThis PR cannot be merged until the following are addressed on its linked issue:
The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically. Maintainers can bypass this check by adding the |
🔴 Playwright Results — workflow failedValidated commit ✅ 0 passed · ❌ 0 failed · 🟡 0 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky Pipeline and setup failures (2)
PerformanceBlocking targets: ✅ met · Optimization targets: 🟡 in progress Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting. 🕒 Full workflow signal wall (to summary) 2h 6m 15s ⏱️ Max setup 1m 34s · max shard execution 7m 49s · max shard-job elapsed before upload 11m 37s · reporting 3s 🌐 121.50 requests/attempt · 1.64 app boots/UI scenario · 0.00% common-shard skew Optimization targets still in progress:
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
2c04577 to
d7134ef
Compare
Code Review ✅ Approved 2 resolved / 2 findingsRefactors the Context Center Memories Playwright test to use memory search helpers and wait for empty-results states, resolving test flakiness and adding the missing semicolon. Consider decoupling the hardcoded limit '10' from the frontend MEMORIES_PER_PAGE constant. ✅ 2 resolved✅ Quality: Missing semicolon on new waitFor statement
✅ Quality: Hardcoded limit '10' couples test to MEMORIES_PER_PAGE constant
OptionsDisplay: compact → Showing less information. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
* Fixed context center memories flaky tests * lint fix * lint fix
Describe your changes:
Fixes #
I worked on ... because ...
Type of change:
High-level design:
N/A — small change.
Tests:
Use cases covered
Unit tests
Backend integration tests
Ingestion integration tests
Playwright (UI) tests
Manual testing performed
UI screen recording / screenshots:
Not applicable.
Checklist:
Fixes <issue-number>: <short explanation>Fixes #<issue-number>above.Greptile Summary
Updates the Context Center Memories Playwright suite to locate memory rows through search and wait for empty search results before restoration.
Confidence Score: 5/5
The PR appears safe to merge.
No blocking failures remain.
Important Files Changed
Reviews (6): Last reviewed commit: "Merge branch 'main' into fix-context-cen..." | Re-trigger Greptile