Skip to content

Fixed context center memories flaky tests#30437

Merged
chirag-madlani merged 5 commits into
mainfrom
fix-context-center-memories-flaky-test
Jul 24, 2026
Merged

Fixed context center memories flaky tests#30437
chirag-madlani merged 5 commits into
mainfrom
fix-context-center-memories-flaky-test

Conversation

@Rohit0301

@Rohit0301 Rohit0301 commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Describe your changes:

Fixes #

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

High-level design:

N/A — small change.

Tests:

Use cases covered

Unit tests

Backend integration tests

Ingestion integration tests

Playwright (UI) tests

Manual testing performed

UI screen recording / screenshots:

Not applicable.

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • My PR is linked to a GitHub issue via Fixes #<issue-number> above.
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
  • For UI changes: I attached a screen recording and/or screenshots above.
  • I have added tests (unit / integration / Playwright as applicable) and listed them above.

Greptile Summary

Updates the Context Center Memories Playwright suite to locate memory rows through search and wait for empty search results before restoration.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failures remain.

Important Files Changed

Filename Overview
openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/ContextCenterMemories.spec.ts Replaces direct row lookup and scrolling with the shared search helper across memory workflows and adds an explicit empty-results wait.

Reviews (6): Last reviewed commit: "Merge branch 'main' into fix-context-cen..." | Re-trigger Greptile

@Rohit0301 Rohit0301 self-assigned this Jul 24, 2026
@Rohit0301
Rohit0301 requested a review from a team as a code owner July 24, 2026 06:32
@Rohit0301 Rohit0301 added the safe to test Add this label to run secure Github workflows on PRs label Jul 24, 2026
@github-actions

Copy link
Copy Markdown
Contributor

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

  • No GitHub issue is linked. Link an issue in the Development section of the PR (or add Fixes #12345 to the description). For a same-org cross-repo issue, add Fixes open-metadata/<repo>#123 to the description.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

🔴 Playwright Results — workflow failed

Validated commit 34a7b61e0a5ab4c03b45578284d20b868296803e in Playwright run 30088248354, attempt 2.

✅ 0 passed · ❌ 0 failed · 🟡 0 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky

Pipeline and setup failures (2)

  • Shard chromium-01 did not upload a usable Playwright results artifact.
  • Shard chromium-01 did not upload its execution status.

Performance

Blocking targets: ✅ met · Optimization targets: 🟡 in progress

Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting.

🕒 Full workflow signal wall (to summary) 2h 6m 15s

⏱️ Max setup 1m 34s · max shard execution 7m 49s · max shard-job elapsed before upload 11m 37s · reporting 3s

🌐 121.50 requests/attempt · 1.64 app boots/UI scenario · 0.00% common-shard skew

Optimization targets still in progress:

  • Application boot ratio was 1.64 per UI scenario (182 boots / 111 scenarios; convergence target: at most 1).
Shard Passed Failed Flaky Skipped Lifecycle failed Lifecycle flaky
⛔ Shard chromium-01

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@Rohit0301
Rohit0301 enabled auto-merge (squash) July 24, 2026 09:13
@Rohit0301
Rohit0301 force-pushed the fix-context-center-memories-flaky-test branch from 2c04577 to d7134ef Compare July 24, 2026 09:18
@chirag-madlani
chirag-madlani disabled auto-merge July 24, 2026 14:04
@chirag-madlani
chirag-madlani merged commit cc87c84 into main Jul 24, 2026
59 of 63 checks passed
@chirag-madlani
chirag-madlani deleted the fix-context-center-memories-flaky-test branch July 24, 2026 14:04
@gitar-bot

gitar-bot Bot commented Jul 24, 2026

Copy link
Copy Markdown
Code Review ✅ Approved 2 resolved / 2 findings

Refactors the Context Center Memories Playwright test to use memory search helpers and wait for empty-results states, resolving test flakiness and adding the missing semicolon. Consider decoupling the hardcoded limit '10' from the frontend MEMORIES_PER_PAGE constant.

✅ 2 resolved
Quality: Missing semicolon on new waitFor statement

📄 openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/ContextCenterMemories.spec.ts:609
The added await page.getByText('No matching results').waitFor({ state: 'visible' }) line has no trailing semicolon, unlike the surrounding code. This violates the project's prettier/eslint formatting rules and will produce a diff/lint failure in CI. Add the semicolon (and run the checkstyle sequence).

Quality: Hardcoded limit '10' couples test to MEMORIES_PER_PAGE constant

📄 openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/ContextCenterMemories.spec.ts:619-628
The restore-response matcher requires limit === '10', which mirrors the frontend MEMORIES_PER_PAGE constant (currently 10). If that constant ever changes, restoreResPromise will never resolve and this test will fail with an opaque timeout rather than a clear assertion. Consider importing/referencing the shared page-size constant (or dropping the limit check and relying on !url.searchParams.has('q')) so the test stays in sync automatically.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

Rohit0301 added a commit that referenced this pull request Jul 24, 2026
* Fixed context center memories flaky tests

* lint fix

* lint fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants