test(e2e): use route.fallback in ETag strip so spec mocks still apply

[ShaileshParmar11]

Describe your changes:

Follow-up to #30371, which introduced stripEtagConditionalReads.

What / why: The ETag strip added in #30371 registered a catch-all page.route('**/api/v1/**') that removed If-None-Match and then called route.continue(). Because Playwright evaluates matching route handlers in reverse registration order (last-registered runs first) and route.continue() terminates the chain, and because the strip is installed via redirectToHomePage after each spec registers its own more-specific route.fulfill() mocks, the catch-all ran first and shadowed those mocks — forwarding the request to the real backend instead of the mocked response.

Change: Switch the strip to route.fallback({ headers }) — Playwright's documented idiom for modifying headers on every request while still allowing other handlers to run. The header is stripped and control defers to the earlier spec-specific mocks; when no other handler exists, fallback continues to the network with the stripped headers, so the original anti-stale-read behavior is byte-for-byte unchanged.

Type of change:

• Bug fix

High-level design:

N/A — small test-infra change.

Tests:

Use cases covered

• E2E specs that mock /api/v1/** endpoints now receive their mocked responses instead of having the ETag catch-all bypass them.
• Specs with no per-URL mock still get If-None-Match stripped and a fresh 200 (unchanged from test(e2e): strip ETag If-None-Match at the network layer #30371).

Unit tests

Not applicable.

Backend integration tests

• Not applicable (no backend API changes).

Ingestion integration tests

• Not applicable (no ingestion changes).

Playwright (UI) tests

• Fixed openmetadata-ui/.../playwright/utils/common.ts (route.continue → route.fallback)
• Re-enabled openmetadata-ui/.../playwright/e2e/Features/ServiceAgentsPauseResume.spec.ts

Manual testing performed

End-to-end confirmation is the Playwright CI run on this branch. The mechanism is verified against Playwright's route-chain semantics: reverse-order handler evaluation + fallback deferring to earlier handlers while preserving header overrides.

UI screen recording / screenshots:

Not applicable — test-only change.

Checklist:

• I have read the CONTRIBUTING document.
• I have commented on my code, particularly in hard-to-understand areas.
• I have added/updated tests.

🤖 Generated with Claude Code

---

Summary by Gitar

• Test infrastructure:
  • Updated waitForIncidentToBeIndexed utility to poll TestCase search for cleared incidentId when verifying resolved status
  • Fixed Data Quality dashboard E2E test assertions for resolved incidents and re-enabled ServiceAgentsPauseResume spec

_{This will update automatically on new commits.}

Greptile Summary

This PR updates Playwright E2E coverage for service-agent pause behavior and resolved data-quality incidents.

• Reworks the service-agent test to use the shared database service, mock toggle and refresh requests, and verify the paused state.
• Polls the TestCase search index for a cleared incidentId before continuing after an incident is resolved.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename	Overview
openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/ServiceAgentsPauseResume.spec.ts	Reworks the pause/resume E2E setup around stateful API mocks and direct navigation to the shared service’s metadata-agent tab.
openmetadata-ui/src/main/resources/ui/playwright/utils/dataQuality.ts	Changes resolved-incident synchronization to wait for the target TestCase search document to have no incident ID.

_{Reviews (6): Last reviewed commit: "Work on the comments" | Re-trigger Greptile}

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[github-actions]

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

• No GitHub issue is linked. Link an issue in the Development section of the PR (or add Fixes #12345 to the description). For a same-org cross-repo issue, add Fixes open-metadata/<repo>#123 to the description.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[github-actions]

🔴 Playwright Results — workflow failed

Validated commit 9a92610f01a387313980f6df6a8d83ebea8bbc28 in Playwright run 30084409774, attempt 1.

✅ 536 passed · ❌ 1 failed · 🟡 1 flaky · ⏭️ 5 skipped · 🧰 0 lifecycle flaky

Performance

Blocking targets: ✅ met · Optimization targets: 🟡 in progress

Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting.

🕒 Full workflow signal wall (to summary) 50m 38s

⏱️ Max setup 2m 56s · max shard execution 15m 19s · max shard-job elapsed before upload 19m 42s · reporting 5s

🌐 199.83 requests/attempt · 2.86 app boots/UI scenario · 13.49% common-shard skew

Optimization targets still in progress:

• Application boot ratio was 2.86 per UI scenario (1606 boots / 561 scenarios; convergence target: at most 1).

Shard	Passed	Failed	Flaky	Skipped	Lifecycle failed	Lifecycle flaky
✅ Shard chromium-01	85	0	0	0	0	0
🟡 Shard chromium-02	100	0	1	0	0	0
✅ Shard chromium-03	111	0	0	0	0	0
🔴 Shard chromium-04	102	1	0	3	0	0
✅ Shard data-asset-rules-01	61	0	0	0	0	0
✅ Shard domain-isolation-01	14	0	0	0	0	0
✅ Shard global-state-01	23	0	0	0	0	0
✅ Shard ingestion-01	1	0	0	0	0	0
✅ Shard reindex-01	2	0	0	0	0	0
✅ Shard search-01	10	0	0	0	0	0
✅ Shard search-rbac-01	27	0	0	2	0	0

Genuine Failures (failed on all attempts)

❌ Features/ServiceAgentsPauseResume.spec.ts › should offer pause for an enabled agent and resume in disabled state (shard chromium-04)

Error: �[2mexpect(�[22m�[31mlocator�[39m�[2m).�[22mtoBeVisible�[2m(�[22m�[2m)�[22m failed  Locator: locator('[data-testid^="agent-card-"][data-testid*="pw-pause-resume-3ce444dd"]') Expected: visible Timeout: 15000ms Error: element(s) not found  Call log: �[2m  - Expect "toBeVisible" with timeout 15000ms�[22m �[2m  - waiting for locator('[data-testid^="agent-card-"][data-testid*="pw-pause-resume-3ce444dd"]')�[22m 

🟡 1 flaky test(s) (passed on retry)

• Pages/Entity.spec.ts › Domain Propagation (shard chromium-02, 1 retry)

📦 Download artifacts

How to debug locally

# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

[Copilot]

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[gitar-bot]

Code Review ✅ Approved 1 resolved / 1 findings

Switches the Playwright ETag-stripping route handler from route.continue() to route.fallback(), allowing spec-specific mocks to execute correctly. No issues found.

✅ 1 resolved

✅ Quality: Unused isOpen=false branch in openCloseAgentActions

📄 openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/ServiceAgentsPauseResume.spec.ts:78-85
openCloseAgentActions(page, isOpen=false) is never invoked with false in this spec (the second test that used the close/no-wait path was removed), so the isOpen parameter and its conditional are dead code, and the helper name implies a close behavior it doesn't implement. Consider simplifying it back to an open-only helper (e.g. openAgentActions) or removing the unused parameter to keep the intent clear.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact

gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Gitar}