Skip to content

remove logging capability from MCP server#26257

Merged
Vishnuujain merged 1 commit intomainfrom
fix/mcp-remove-logging-capability
Mar 6, 2026
Merged

remove logging capability from MCP server#26257
Vishnuujain merged 1 commit intomainfrom
fix/mcp-remove-logging-capability

Conversation

@Vishnuujain
Copy link
Contributor

Describe your changes:

Fixes #26152

Because we use a stateless HTTP architecture for our MCP server, we physically cannot support MCP's push-based logging notifications (which require a persistent connection like SSE or WebSockets). The underlying Java SDK (McpStatelessAsyncServer) doesn't even have a handler for logging/setLevel in stateless mode, which is exactly why VSCode is throwing that error.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Vishnuujain Vishnuujain added safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch labels Mar 5, 2026
@Vishnuujain Vishnuujain force-pushed the fix/mcp-remove-logging-capability branch from 1640c82 to 7d294f0 Compare March 5, 2026 10:28
@gitar-bot
Copy link

gitar-bot bot commented Mar 5, 2026

Code Review ✅ Approved

Removes unimplemented logging capability from MCP server to clean up unused code. No issues found.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@Vishnuujain Vishnuujain merged commit fec861f into main Mar 6, 2026
30 of 33 checks passed
@Vishnuujain Vishnuujain deleted the fix/mcp-remove-logging-capability branch March 6, 2026 16:31
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

Changes have been cherry-picked to the 1.12.2 branch.

github-actions bot pushed a commit that referenced this pull request Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MCP Server advertises 'logging' capability but 'logging/setLevel' is unimplemented

2 participants