remove logging capability from MCP server#26257
Merged
Vishnuujain merged 1 commit intomainfrom Mar 6, 2026
Merged
Conversation
1640c82 to
7d294f0
Compare
Code Review ✅ ApprovedRemoves unimplemented logging capability from MCP server to clean up unused code. No issues found. OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
mohityadav766
approved these changes
Mar 6, 2026
Contributor
|
Changes have been cherry-picked to the 1.12.2 branch. |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 6, 2026
(cherry picked from commit fec861f)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixes #26152
Because we use a stateless HTTP architecture for our MCP server, we physically cannot support MCP's push-based logging notifications (which require a persistent connection like SSE or WebSockets). The underlying Java SDK (McpStatelessAsyncServer) doesn't even have a handler for logging/setLevel in stateless mode, which is exactly why VSCode is throwing that error.
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>