Skip to content

Fix (UI): Flaky DataConsumer Spec#25197

Merged
dhruvjsx merged 10 commits intoopen-metadata:mainfrom
dhruvjsx:fix-flaky-dataconsumer
Jan 13, 2026
Merged

Fix (UI): Flaky DataConsumer Spec#25197
dhruvjsx merged 10 commits intoopen-metadata:mainfrom
dhruvjsx:fix-flaky-dataconsumer

Conversation

@dhruvjsx
Copy link
Copy Markdown
Contributor

@dhruvjsx dhruvjsx commented Jan 9, 2026

Describe your changes:

Screenshot 2026-01-10 at 1 42 59 AM Screenshot 2026-01-09 at 2 00 14 PM

I worked on ... because ...


Summary by Gitar

  • Fixed flaky Playwright tests:
    • Enhanced updateDescriptionForChildren in playwright/utils/entity.ts with proper input state validation
  • Improved test stability:
    • Added explicit waits for element visibility and editability before interaction
    • Replaced direct .clear() with keyboard commands (Meta+A + Backspace) for reliable input clearing
  • Added assertions:
    • Verify input is empty before filling and contains expected text after, preventing race conditions

This will update automatically on new commits.


Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 9, 2026

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@sonarqubecloud
Copy link
Copy Markdown

@dhruvjsx dhruvjsx merged commit ed4e8db into open-metadata:main Jan 13, 2026
29 of 31 checks passed
dhruvjsx added a commit that referenced this pull request Jan 13, 2026
* fixed flaky data consumer tests

* removed unncessary wait for selector

* fixed tests

* avoinding flaky errors

* removed unncessary code

* removed timeout

* fixed annoucnemt flaky test

* fixed flaky test

* added timeout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants