fix: expand example for 1.3.3.1#387
Open
dd-oleksii wants to merge 1 commit into
Open
Conversation
- add example of getLongValue (consistent with java idioms) - fix typing for getFloatValue (long -> double) Signed-off-by: Oleksii Shmalko <oleksii.shmalko@datadoghq.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Java code snippet in the flag evaluation specification. It replaces the incorrect getFloatValue method (which returned a long) with two correct method signatures: getLongValue returning a long and getDoubleValue returning a double. There are no review comments, and I have no additional feedback to provide.
Contributor
Author
|
CI failed because of github incident: https://www.githubstatus.com/incidents/gnftqj9htp0g |
nicklasl
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Expand example for additional number getters.
Related Issues
open-feature/java-sdk#501 (comment)