chore(deps): bump protobuf to 7.35.1#400
Conversation
|
Warning Review limit reached
Next review available in: 58 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated protobuf-related dependency constraints in ChangesDependency Version Update
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Juliano Costa <juliano.costa@datadoghq.com>
b73c967 to
364371a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #400 +/- ##
==========================================
+ Coverage 95.62% 96.28% +0.65%
==========================================
Files 24 47 +23
Lines 1029 1750 +721
==========================================
+ Hits 984 1685 +701
- Misses 45 65 +20 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR updates the openfeature-provider-flagd provider to allow and lock a newer protobuf major version (resolving to protobuf==7.35.1) by widening the upper bound from <7.0.0 to <8.0.0, and refreshing the lockfile accordingly.
Changes:
- Widen
openfeature-provider-flagdruntime dependency constraint toprotobuf>=6.30.0,<8.0.0. - Widen
types-protobufdev dependency constraint to>=6.30.0,<8.0.0. - Refresh
uv.lock, resulting inprotobuf==7.35.1and updated related packages (notablygrpcio/grpcio-health-checking).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
uv.lock |
Updates the resolved dependency set, including protobuf==7.35.1 and related gRPC packages. |
providers/openfeature-provider-flagd/pyproject.toml |
Widens protobuf and types-protobuf version constraints for the openfeature-provider-flagd provider. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Raise protobuf/types-protobuf floor to >=7.0.0 instead of just widening the ceiling, since the only breaking change in protobuf 7 was dropping Python 3.9 support (already dropped here). - Raise grpcio-health-checking dev dependency floor to >=1.82.0, the first release compatible with protobuf<8.0.0, so lowest-version resolution can't reintroduce the original lock conflict. - Document why the Hatch protobuf build hook stays pinned to protobuf~=6.0: hatch-protobuf depends on grpcio-tools, which only supports protobuf 7 in pre-releases so far. This is an isolated build-time environment; generated stubs remain compatible with the protobuf>=7.0.0 runtime requirement. Signed-off-by: Juliano Costa <juliano.costa@datadoghq.com>
Remove comments and update protobuf dependency version. Signed-off-by: Juliano Costa <juliano.costa@datadoghq.com>
|
Reviews addressed ✅ |
This PR
Bumps protobuf from >=6.30.0,<7.0.0 to >=6.30.0,<8.0.0 in openfeature-provider-flagd, resolving to 7.35.1.
This supersedes #353, which was auto-closed by Renovate after failing to lock. At the time,
grpcio-health-checking(dev dependency) cappedprotobuf<7.0.0. That's no longer the case,grpcio-health-checking1.82.0now supportsprotobuf<8.0.0,>=6.33.5, so the upgrade path is clear.Related Issues
open-telemetry/opentelemetry-demo#3646