Skip to content

chore(deps): bump protobuf to 7.35.1#400

Merged
gruebel merged 3 commits into
open-feature:mainfrom
julianocosta89:chore/bump-protobuf
Jul 8, 2026
Merged

chore(deps): bump protobuf to 7.35.1#400
gruebel merged 3 commits into
open-feature:mainfrom
julianocosta89:chore/bump-protobuf

Conversation

@julianocosta89

Copy link
Copy Markdown
Contributor

This PR

Bumps protobuf from >=6.30.0,<7.0.0 to >=6.30.0,<8.0.0 in openfeature-provider-flagd, resolving to 7.35.1.

This supersedes #353, which was auto-closed by Renovate after failing to lock. At the time, grpcio-health-checking (dev dependency) capped protobuf<7.0.0. That's no longer the case,grpcio-health-checking 1.82.0 now supports protobuf<8.0.0,>=6.33.5, so the upgrade path is clear.

Related Issues

open-telemetry/opentelemetry-demo#3646

@julianocosta89 julianocosta89 requested review from a team as code owners July 7, 2026 09:44
@github-actions github-actions Bot requested review from aepfli and federicobond July 7, 2026 09:45
@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@julianocosta89, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 58 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 725f11fd-83e0-4451-86ab-6560c4e84722

📥 Commits

Reviewing files that changed from the base of the PR and between 294d3f9 and 9f90d04.

📒 Files selected for processing (1)
  • providers/openfeature-provider-flagd/pyproject.toml
📝 Walkthrough

Walkthrough

Updated protobuf-related dependency constraints in providers/openfeature-provider-flagd/pyproject.toml, widening runtime and dev version bounds and adding a build-hook compatibility comment.

Changes

Dependency Version Update

Layer / File(s) Summary
Protobuf dependency bounds and build hook
providers/openfeature-provider-flagd/pyproject.toml
protobuf, grpcio-health-checking, and types-protobuf version constraints were updated, and the hatch protobuf build hook gained a compatibility comment.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: bumping protobuf to 7.35.1.
Description check ✅ Passed The description matches the dependency update and explains the grpcio-health-checking blocker.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: Juliano Costa <juliano.costa@datadoghq.com>
@codecov

codecov Bot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.28%. Comparing base (9c493b8) to head (9f90d04).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #400      +/-   ##
==========================================
+ Coverage   95.62%   96.28%   +0.65%     
==========================================
  Files          24       47      +23     
  Lines        1029     1750     +721     
==========================================
+ Hits          984     1685     +701     
- Misses         45       65      +20     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the openfeature-provider-flagd provider to allow and lock a newer protobuf major version (resolving to protobuf==7.35.1) by widening the upper bound from <7.0.0 to <8.0.0, and refreshing the lockfile accordingly.

Changes:

  • Widen openfeature-provider-flagd runtime dependency constraint to protobuf>=6.30.0,<8.0.0.
  • Widen types-protobuf dev dependency constraint to >=6.30.0,<8.0.0.
  • Refresh uv.lock, resulting in protobuf==7.35.1 and updated related packages (notably grpcio / grpcio-health-checking).

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.

File Description
uv.lock Updates the resolved dependency set, including protobuf==7.35.1 and related gRPC packages.
providers/openfeature-provider-flagd/pyproject.toml Widens protobuf and types-protobuf version constraints for the openfeature-provider-flagd provider.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread providers/openfeature-provider-flagd/pyproject.toml Outdated
Comment thread providers/openfeature-provider-flagd/pyproject.toml Outdated
Comment thread providers/openfeature-provider-flagd/pyproject.toml Outdated
@beeme1mr beeme1mr requested review from a team and toddbaert July 8, 2026 01:52
- Raise protobuf/types-protobuf floor to >=7.0.0 instead of just
  widening the ceiling, since the only breaking change in protobuf 7
  was dropping Python 3.9 support (already dropped here).
- Raise grpcio-health-checking dev dependency floor to >=1.82.0, the
  first release compatible with protobuf<8.0.0, so lowest-version
  resolution can't reintroduce the original lock conflict.
- Document why the Hatch protobuf build hook stays pinned to
  protobuf~=6.0: hatch-protobuf depends on grpcio-tools, which only
  supports protobuf 7 in pre-releases so far. This is an isolated
  build-time environment; generated stubs remain compatible with the
  protobuf>=7.0.0 runtime requirement.

Signed-off-by: Juliano Costa <juliano.costa@datadoghq.com>
Remove comments and update protobuf dependency version.

Signed-off-by: Juliano Costa <juliano.costa@datadoghq.com>
@julianocosta89

Copy link
Copy Markdown
Contributor Author

Reviews addressed ✅

@gruebel gruebel merged commit a7cc860 into open-feature:main Jul 8, 2026
60 checks passed
@julianocosta89 julianocosta89 deleted the chore/bump-protobuf branch July 8, 2026 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants