-
Notifications
You must be signed in to change notification settings - Fork 58
feat: supply bound domain to provider initialization #1982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jonathannorris
wants to merge
11
commits into
main
Choose a base branch
from
feat/domain-scoped-provider-init
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
24820d8
feat: supply bound domain to provider initialization
jonathannorris e47580a
refactor: use javax.annotation.Nullable for domain parameter
jonathannorris c2155b8
test: cover initialize default method backward compatibility
jonathannorris cc554a0
test: tighten ProviderFixture initialize mock matchers
jonathannorris 3733e27
test: align initialize mock matchers across PR test updates
jonathannorris e9af1a0
fix: address review feedback and forward domain in MultiProvider
jonathannorris 43ef8fd
test: stabilize shared-provider multi-domain binding assertion
jonathannorris 50a5dcc
test: improve coverage for domain-scoped provider binding paths
jonathannorris db2fe7f
fix: use instance identity for domain-scoped provider binding
jonathannorris 362bcce
test: shutdown OpenFeatureAPI after each domain-scoped spec test
jonathannorris c0ed5b7
fixup: vmlens test, remove nullable, tighten provider-repo logic
toddbaert File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,3 +15,4 @@ target | |
|
|
||
| # used for spec compliance tooling | ||
| java-report.json | ||
| .worktrees/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Forward the
isDomainScoped()constraint from child providers.If a child provider is domain-scoped, it relies on the SDK's
ProviderRepositoryto eagerly reject bindings to multiple domains. However, sinceMultiProviderdoes not overrideisDomainScoped(), it defaults tofalse.This allows a
MultiProviderthat wraps a domain-scoped child to be bound to multiple domains, silently bypassing the SDK's validation and subjecting the child provider to multiple initializations with different domains.Consider overriding
isDomainScoped()to dynamically reflect the strictest constraints of the child providers.💡 Proposed fix to add constraint propagation
Apply this snippet anywhere within the
MultiProviderclass:📝 Committable suggestion
🤖 Prompt for AI Agents