Skip to content

feat: Overload client functions - #129

Open
NeaguGeorgiana23 wants to merge 36 commits into
mainfrom
overload_client_functions
Open

feat: Overload client functions#129
NeaguGeorgiana23 wants to merge 36 commits into
mainfrom
overload_client_functions

Conversation

@NeaguGeorgiana23

Copy link
Copy Markdown
Contributor

This PR

  • Adds EvaluationOptions overloads for all typed flag evaluation methods (GetBooleanValue, GetStringValue, GetIntegerValue, GetDoubleValue, GetObjectValue) in the Features interface and ClientAPI implementation per OpenFeature Specification Requirements 1.3.1.1 and 1.5.1.
  • Supports both (flag_key, default_value, options) and (flag_key, default_value, context, options) call signatures.
  • Updates ClientAPI::EvaluateFlag and private typed evaluation helpers to accept and propagate std::optional<EvaluationOptions>.
  • Adds :evaluation_options dependency to the :features library target in openfeature/BUILD.
  • Adds unit tests in test/client_api_test.cpp verifying each typed evaluation method with EvaluationOptions and combined EvaluationContext + EvaluationOptions.

Related Issues

Fixes #128

Notes

  • These overloads enable passing invocation-specific hooks (options.hooks) and metadata hints (options.hook_hints) to individual evaluation calls.

Follow-up Tasks

  • Implement the full hook execution lifecycle in ClientAPI::EvaluateFlag to execute invocation-level hooks and propagate HookHints.
  • Add detailed flag evaluation methods (Get*Details) returning `Flag

NeaguGeorgiana23 and others added 30 commits July 7, 2026 13:19
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <115723925+NeaguGeorgiana23@users.noreply.github.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
@NeaguGeorgiana23
NeaguGeorgiana23 requested review from a team as code owners August 10, 2026 22:58
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@NeaguGeorgiana23, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 16 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a230d844-cbed-4435-8115-ab39eea8406e

📥 Commits

Reviewing files that changed from the base of the PR and between 4c1bb41 and 408322e.

📒 Files selected for processing (14)
  • openfeature/BUILD
  • openfeature/client.h
  • openfeature/client_api.cpp
  • openfeature/client_api.h
  • openfeature/features.h
  • openfeature/flag_evaluation_details.h
  • openfeature/hook.h
  • openfeature/openfeature.h
  • openfeature/openfeature_api.cpp
  • openfeature/openfeature_api.h
  • test/BUILD
  • test/client_api_test.cpp
  • test/hook_test.cpp
  • test/openfeature_api_test.cpp

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Overload functions to add support for EvaluationOptions

1 participant