Skip to content

Fix shell injection in Nautilus extension #1407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thistehneisen wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −11
Open

Fix shell injection in Nautilus extension #1407

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions extensions/nautilus/nautilus-qdigidoc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
# License along with this library; if not, write to the Free Software
# Foundation, Inc, 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
#
import os
import subprocess
import gettext
import locale
import gi
Expand All @@ -37,11 +37,7 @@ def __init__(self):
super().__init__()

def menu_activate_cb(self, menu, paths):
args = "-sign "
for path in paths:
args += "\"%s\" " % path
cmd = ("qdigidoc4 " + args + "&")
os.system(cmd)
subprocess.Popen(["qdigidoc4", "-sign", *paths])

def valid_file(self, file):
return file.get_file_type() == Gio.FileType.REGULAR and file.get_uri_scheme() == 'file'
Expand Down Expand Up @@ -81,11 +77,7 @@ def __init__(self):
super().__init__()

def menu_activate_cb(self, menu, paths):
args = "-crypto "
for path in paths:
args += "\"%s\" " % path
cmd = ("qdigidoc4 " + args + "&")
os.system(cmd)
subprocess.Popen(["qdigidoc4", "-crypto", *paths])

def valid_file(self, file):
return file.get_file_type() == Gio.FileType.REGULAR and file.get_uri_scheme() == 'file'
Expand Down
Loading