docs: require PR_TITLE and PR_BODY for squash merges - #72
Conversation
![rianjs-bot[bot]](https://avatars.githubusercontent.com/u/7378790?s=60&v=4){kind=small}
There was a problem hiding this comment.
Automated PR Review
Reviewed commit: 8da41445d945
Profile: codex-rianjs-bot - Posting as: rianjs-bot[bot]
Summary
| Reviewer | Findings |
|---|---|
| documentation:docs | 1 |
| policies:conventions | 0 |
documentation:docs (1 finding)
Minor - docs/repo-layout.md:204
This new mandatory
PR_BODYsetting conflicts with §7's still-current description that the landing commit may contain either the PR description or branch commit messages, and that both squash-message modes are covered. That could lead maintainers to configure or reason about the prohibited commit-message mode. Update §7 to describe the now-required PR-title/PR-body shape and its corresponding CI coverage.
Reviewer Coverage
| Reviewer | Status | Inspected | Skipped | Constraints |
|---|---|---|---|---|
| documentation:docs | complete_broad | docs/release.md, docs/repo-layout.md | unavailable | Documentation-only review; the artifact checkout's Git metadata was not usable, so review relied on the supplied change map and inspected final documentation. |
| policies:conventions | complete_broad | docs/release.md, docs/repo-layout.md | unavailable | Repository Git metadata was not accessible through the review environment, so the review used the supplied change map/intent and the checked-out document content. |
0 PR discussion threads considered. 0 summarized; 0 resolved.
Completed in 36m 38s | unavailable | gpt-5.6-terra | cr 0.10.270
| Field | Value |
|---|---|
| Model | gpt-5.6-terra |
| Reviewers | documentation:docs, policies:conventions |
| Engine | codex_cli · gpt-5.6-terra |
| Reviewed by | cr · rianjs-bot[bot] |
| Duration | 36m 38s wall · 1h 12m compute |
| Cost | unavailable |
| Tokens | 484.3k in / 6.6k out |
Per-workstream usage
| Workstream | Model | In | Out | Cache read | Cache create | Cost | Duration |
|---|---|---|---|---|---|---|---|
| orchestrator-selection | gpt-5.6-terra | 16.6k | 190 | 11.0k | unavailable | unavailable | 6s |
| documentation:docs | gpt-5.6-terra | 245.3k | 3.8k | 207.9k | unavailable | unavailable | 36m 18s |
| policies:conventions | gpt-5.6-terra | 187.7k | 2.3k | 152.8k | unavailable | unavailable | 35m 52s |
| orchestrator-rollup | gpt-5.6-terra | 34.7k | 287 | 27.1k | unavailable | unavailable | 5s |
| ### Merge settings | ||
| - **Squash merge only** (no merge commits, no rebase merge). This is why the PR | ||
| title must be a conventional commit (`release.md` §1). | ||
| - Set `squash_merge_commit_title=PR_TITLE` and |
There was a problem hiding this comment.
This new mandatory PR_BODY setting conflicts with §7's still-current description that the landing commit may contain either the PR description or branch commit messages, and that both squash-message modes are covered. That could lead maintainers to configure or reason about the prohibited commit-message mode. Update §7 to describe the now-required PR-title/PR-body shape and its corresponding CI coverage.
Reply inline to this comment.
There was a problem hiding this comment.
Addressed in 5cb1ed0: §7 now describes only the required PR_TITLE/PR_BODY landing shape and the corresponding PR title/body CI coverage. The prohibited COMMIT_MESSAGES alternative is no longer presented. make check passes.
1 participant
Summary
squash_merge_commit_title=PR_TITLEandsquash_merge_commit_message=PR_BODYin the repository-settings standard.COMMIT_OR_PR_TITLEbypass and the release dependency inrelease.md.Validation
make checkgit diff --checkCloses #71