Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
d35da6b
new ga plot
AgnieszkaZaba Mar 18, 2026
cb47394
Revert "Refine citation with DOI link (#1813)"
AgnieszkaZaba Mar 18, 2026
fae09de
add `r` to string formatting; update temperature
AgnieszkaZaba Mar 18, 2026
7d0074d
plot update
AgnieszkaZaba Mar 19, 2026
17fbfab
set dm dependence on RH
AgnieszkaZaba Mar 19, 2026
1988345
pristine vs polluted
AgnieszkaZaba Mar 23, 2026
6e2a7f1
add label
AgnieszkaZaba Mar 23, 2026
590bde5
comparison for pristine and polluted?
AgnieszkaZaba Mar 23, 2026
91d22af
plots with swm const
AgnieszkaZaba Mar 23, 2026
942b91c
dm_dt total is the same
AgnieszkaZaba Mar 23, 2026
4c3c350
dm_dt total is the same, fix
AgnieszkaZaba Mar 23, 2026
7bb9595
add delta on z axis; new plot for pristine vs polluted (2D)
AgnieszkaZaba Mar 25, 2026
72a76fd
make plots beautiful
AgnieszkaZaba Mar 25, 2026
5be98bb
add description
AgnieszkaZaba Mar 26, 2026
75fe80d
Bolin number in return, asserts
AgnieszkaZaba Mar 30, 2026
a298b61
add removed todo
AgnieszkaZaba Mar 30, 2026
bf7ddbe
fix units in test
AgnieszkaZaba Apr 1, 2026
a42b788
fix Bolin formula; units were wrong
AgnieszkaZaba Apr 1, 2026
cfb2d19
remove dependence on time from Bo and dR/dt; small fixes
AgnieszkaZaba Apr 1, 2026
ba1160c
remove Bo calculation (was for debug)
AgnieszkaZaba Apr 1, 2026
4ecb3c5
figure for iso equil using Bo
AgnieszkaZaba Apr 2, 2026
dcb8956
insert values in text; small cleanup - remove attr used once
AgnieszkaZaba Apr 4, 2026
6e224d4
separate code, move to new files
AgnieszkaZaba Apr 5, 2026
9d4f013
revert - will be in new pr
AgnieszkaZaba Apr 14, 2026
b0d09b5
add information about AMS summit; rerun notebook
AgnieszkaZaba Apr 14, 2026
bc2b964
revert - will be in new pr
AgnieszkaZaba Apr 14, 2026
17edda8
address pylint hints
AgnieszkaZaba Apr 14, 2026
19964fd
ENG British, update tests
AgnieszkaZaba Apr 14, 2026
cb82e3f
docstring
AgnieszkaZaba Apr 14, 2026
61d519c
annotate todo
AgnieszkaZaba Apr 14, 2026
b5829bd
address pylint
AgnieszkaZaba Apr 14, 2026
f36dd29
updates in notebook; make test less strict due to high sensitivity to…
AgnieszkaZaba Apr 17, 2026
3771356
removing jetTransient JSON entries
slayoo Apr 18, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion PySDM/attributes/isotopes/bolin_numbers.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ def __init__(self, builder, *, heavy_isotope: str):
Heavy isotopologue identifier (entry of ``HEAVY_ISOTOPES``).
"""
self.moles_heavy = builder.get_attribute(f"moles_{heavy_isotope}")
self.moles_light = builder.get_attribute("moles light water")
self.moles_light = builder.get_attribute("moles light water") # TODO #1787
self.cell_id = builder.get_attribute("cell id")
self.molality_in_dry_air = builder.particulator.environment[
f"molality {heavy_isotope} in dry air"
Expand Down
11 changes: 4 additions & 7 deletions PySDM/backends/impl_numba/methods/isotope_methods.py
Original file line number Diff line number Diff line change
Expand Up @@ -64,19 +64,16 @@ def body(
moles_heavy_molecule,
bolin_number,
molality_in_dry_air,
):
): # pylint: disable=too-many-locals
for sd_id in range(multiplicity.shape[0]):
Bo = bolin_number[sd_id]
mass_ratio_heavy_to_total = (
moles_heavy_molecule[sd_id] * molar_mass_heavy_molecule
) / signed_water_mass[sd_id]
if bolin_number[sd_id] == 0:
if Bo == 0:
dm_heavy = 0
else:
dm_heavy = (
dm_total[sd_id]
/ bolin_number[sd_id]
* mass_ratio_heavy_to_total
)
dm_heavy = dm_total[sd_id] / Bo * mass_ratio_heavy_to_total
dn_heavy_molecule = dm_heavy / molar_mass_heavy_molecule
moles_heavy_molecule[sd_id] += dn_heavy_molecule
mass_of_dry_air = (
Expand Down
6 changes: 3 additions & 3 deletions PySDM/physics/constants_defaults.py
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@
[Kaercher & Lohmann 2002](https://doi.org/10.1029/2001JD000470) """
HAC_ice = 1.0
""" thermal accommodation coefficient for vapour deposition as recommended in
[Pruppacher & Klett 2010](https://doi.org/10.1007/978-0-306-48100-0) """
[Pruppacher & Klett](https://doi.org/10.1007/978-0-306-48100-0) """

C_cunn = 0.7
""" Cunningham correction factor as used in
Expand Down Expand Up @@ -222,12 +222,12 @@
""" 〃 """

dv_pk05 = 0.0 * si.metres
""" Delta v for diffusivity in [Pruppacher & Klett 2010](https://doi.org/10.1007/978-0-306-48100-0)
""" Delta v for diffusivity in [Pruppacher & Klett](https://doi.org/10.1007/978-0-306-48100-0)
eq. 13-14 """

lmbd_w_0 = 6.6e-8 * si.metre
""" Mean free path of water molecules as in table 13.1 in
[Pruppacher & Klett 2010](https://doi.org/10.1007/978-0-306-48100-0) """
[Pruppacher & Klett](https://doi.org/10.1007/978-0-306-48100-0) """

d_l19_a = 0.211e-4 * si.metre**2 / si.second
""" [Seinfeld & Pandis](https://archive.org/details/0237-pdf-atmospheric-chemistry-and-physics-2nd-ed-j.-seinfeld-s.-pandis-wiley-2006-ww)
Expand Down
2 changes: 1 addition & 1 deletion PySDM/physics/diffusion_kinetics/grabowski_et_al_2011.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
as in [Grabowski et al. (2011)](https://doi.org/10.1016/j.atmosres.2010.10.020)
"""

from .pruppacher_and_klett_2010 import PruppacherKlett
from .pruppacher_and_klett_2005 import PruppacherKlett


class GrabowskiEtAl2011(PruppacherKlett):
Expand Down
6 changes: 3 additions & 3 deletions PySDM/physics/diffusion_kinetics/lowe_et_al_2019.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
"""
as in [Lowe et al. 2019](https://doi.org/10.1038/s41467-019-12982-0)
uses eq. 13-14 in [Pruppacher & Klett 2010](https://doi.org/10.1007/978-0-306-48100-0)
with Delta v = 0 and no corrections for thermal conductivity
uses eq. 13-14 in [Pruppacher & Klett](https://doi.org/10.1007/978-0-306-48100-0) with Delta v = 0
and no corrections for thermal conductivity
"""

from PySDM.physics.diffusion_kinetics.pruppacher_and_klett_2010 import PruppacherKlett
from PySDM.physics.diffusion_kinetics.pruppacher_and_klett_2005 import PruppacherKlett


class LoweEtAl2019(PruppacherKlett):
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
"""
as in [Pruppacher & Klett 2010](https://doi.org/10.1007/978-0-306-48100-0) (eq. 13-14)
as in Pruppacher and Klett 2005 (eq. 13-14)
with reference to [Okuyama and Zung 1967](https://doi.org/10.1063/1.1840906)
"""

Expand Down
5 changes: 4 additions & 1 deletion PySDM/physics/isotope_relaxation_timescale/zaba_et_al.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ def tau(

@staticmethod
def bolin_number(
const,
D_ratio_heavy_to_light,
alpha,
D_light,
Expand All @@ -42,8 +43,10 @@ def bolin_number(
* (1 - relative_humidity)
/ D_ratio_heavy_to_light
/ (
(1 + rho_v * D_light * Fk)
(1 + rho_v * D_light * Fk / const.rho_w)
* relative_humidity
* (1 - alpha * R_vap / R_liq)
- relative_humidity
+ 1
)
)
5 changes: 2 additions & 3 deletions docs/bibliography.json
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@
},
"https://doi.org/10.1063/1.1840906": {
"usages": [
"PySDM/physics/diffusion_kinetics/pruppacher_and_klett_2010.py"
"PySDM/physics/diffusion_kinetics/pruppacher_and_klett_2005.py"
],
"label": "Okuyama & Zung 1967 (J. Chem. Phys. 1967)",
"title": "Evaporation—Condensation Coefficient for Small Droplets"
Expand Down Expand Up @@ -789,8 +789,7 @@
"https://doi.org/10.1007/978-0-306-48100-0": {
"usages": [
"PySDM/physics/constants_defaults.py",
"PySDM/physics/diffusion_kinetics/lowe_et_al_2019.py",
"PySDM/physics/diffusion_kinetics/pruppacher_and_klett_2010.py"
"PySDM/physics/diffusion_kinetics/lowe_et_al_2019.py"
],
"title": "Microphysics of Clouds and Precipitation",
"label": "Pruppacher & Klett 2010 (Springer Dordrecht)"
Expand Down
Loading
Loading