Fix another very tricky bug related to web_connectivity 0.5 DNS mapping - #181
Open
hellais wants to merge 1 commit into
Open
Fix another very tricky bug related to web_connectivity 0.5 DNS mapping#181hellais wants to merge 1 commit into
hellais wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #181 +/- ##
==========================================
+ Coverage 77.87% 83.55% +5.67%
==========================================
Files 33 89 +56
Lines 1939 5892 +3953
==========================================
+ Hits 1510 4923 +3413
- Misses 429 969 +540
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The transaction_id is what identifies a single connection to an endpoint, so when we know it, every observation of that connection shares it. In these cases matching against the IP address is wrong, since an endpoint might be reached on the same IP multiple times (eg. once over port 80 and twice over 443 in the case of web_connectivity 0.5), so matching only on the address will mix together observations that are for different connections.
DNS queries also carry a transaction_id, but it doesn't necessarily identify the connections which follow. The web_connectivity 0.5 spec says that it SHOULD use a different ID space than connections, while other nettests the whole transaction including the query might share the same ID.
Callers mapping a DNS observation onto TCP and TLS should pass is_connection_transaction_id=False, so that the ID is only used when it actually matches, and the connection is identified via the address otherwise.
related to: #180