Complete pkg_resources removal for Python 3.14 + dependency/CI cleanup#15
Open
onlykey wants to merge 5 commits into
Open
Complete pkg_resources removal for Python 3.14 + dependency/CI cleanup#15onlykey wants to merge 5 commits into
onlykey wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the previous pkg_resources PR, which swapped pkg_resources for importlib.metadata but was incomplete and introduced a regression.
Fixes. age: removed the leftover pkg_resources.require(...) call the previous PR missed -- it referenced pkg_resources after the import was deleted, raising NameError on the --version path. signify: removed the stray import pkg_resources the previous PR did not touch; this is the import that fails on Python 3.14.
Cleanup. setup.py drops wheel (build-only) and backports.shutil_which (py2), de-dups python-daemon, and adds python_requires '>=3.8'. util.py uses shutil.which directly. CI matrix is now 3.8 through 3.14 (was 3.7-3.11), with checkout v4 / setup-python v5.
Verification. All modules import on Python 3 and --version works; the test suite passes apart from one pre-existing, unrelated ssh signature test. (Separately, the repo's existing tox lint step is already red on master, independent of this change.)
Addresses the Python 3.14 failure reported in onlykey-agent (issue 45); a 1.0.7 release should ship before that issue is closed.