Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
|
Thanks a lot for this contribution! This is a substantial PR so we'll need some time to review it properly. Will follow up with detailed feedback once we've gone through everything. |
|
No problem! Let me know if there is anything that needs re-thinking. Happy to help :) |
|
Thanks for the detailed PR! I've done an initial review and the overall structure looks solid - clean separation, good test coverage, and consistent use of parameterized SQL. A few things I'd like to address before merging: Query bounds:
Minor code issues:
Typo:
Worth considering (non-blocking):
Happy to discuss any of these. Nice work on the docs and Python examples. |
|
Glad that the PR looks good - I've gone through your comments and made these changes: -
I didn't change Also had a couple thoughts with where to take this next. Won't be doing it anytime soon, but any thoughts?
Let me know if somethings not right, or if we should make more changes before merging :) |
99d54b4 to
6052ff6
Compare
Summary
Adds API Integrations as a new telemetry subsystem for tracking token and cost usage from custom API-driven scripts via local JSONL ingestion.
What Changed
Notes
ONWATCH_API_INTEGRATIONS_ENABLEDONWATCH_API_INTEGRATIONS_DIRTesting
go test -race ./...go vet ./...examples/api_integrations/pythonalong with .py examples and JSONL wrapper.Screenshots!