refactor: ♻️ turn foer_besoegsdag into a single resource#93
Open
joelostblom wants to merge 6 commits into
Open
refactor: ♻️ turn foer_besoegsdag into a single resource#93joelostblom wants to merge 6 commits into
joelostblom wants to merge 6 commits into
Conversation
Normalize foer_besoegsdag visit-specific forms into one resource schema with a visit field so repeated workflow metadata is represented by rows instead of suffixed resources.
Only remove foer_besoegsdag visit suffixes for the joined visits so descriptions keep meaningful references to other visits and avoid doubled punctuation.
Update generated metadata so foer_besoegsdag visits 2, 3, and 4 share one resource with a visit key and normalized workflow fields.
Build the before-visit field-to-visits map with a reducer so common workflow fields are identified without nested filtering comprehensions.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge after #90
Description
This PR combines got a little bit more messy than the other ones because some fields were not in part of each visit and therefore some of them changed from being required to being optional.
But overall this PR does the following:
foer_besoegsdag_2,foer_besoegsdag_3, andfoer_besoegsdag_4into onefoer_besoegsdagresource.visitfield with values2,3, and4, and include it in the primary key withevent._wfv2,_wfv3, and_wfv4suffixes.Visit 2,Visit 3,Visit 4, andWfv2/Wfv3/Wfv4when it only repeats the newvisitfield.Closes #54
This PR needs an in-depth review.
Checklist
just run-all