refactor: ♻️ convert column time suffixes to its own variable in VAS#89
Open
joelostblom wants to merge 7 commits into
Open
refactor: ♻️ convert column time suffixes to its own variable in VAS#89joelostblom wants to merge 7 commits into
joelostblom wants to merge 7 commits into
Conversation
lwjohnst86
requested changes
May 26, 2026
Member
lwjohnst86
left a comment
lwjohnst86
left a comment
There was a problem hiding this comment.
Nicely reduces the number of tables we have 🎉 just some comments and changes.
github-project-automation
Bot
moved this from In review
to In progress
in Data development
martonvago
reviewed
May 26, 2026
Join vas_minus10 into the combined VAS resource using minutes_from_meal so negative and positive meal-relative timepoints share one schema.
Remove the redundant vas_ prefix from variables after they are moved into the combined VAS resource.
Use descriptive title and description values for the combined VAS resource and make VAS field deduplication easier to read.
joelostblom
commented
May 27, 2026
Author
joelostblom
left a comment
joelostblom
left a comment
There was a problem hiding this comment.
Thanks for the comments; updated accordingly!
joelostblom
commented
May 27, 2026
1 task
lwjohnst86
changed the title
lwjohnst86
requested changes
May 28, 2026
Member
lwjohnst86
left a comment
lwjohnst86
left a comment
There was a problem hiding this comment.
Looking very nice, only two suggested changes (plus asking @K-Beicher about the title).
|
|
||
| def _get_resource_title(form_name: str) -> str: | ||
| if form_name == "vas": | ||
| return "Visual analogue scale measurements" |
Member
There was a problem hiding this comment.
@K-Beicher is this an accurate title for this resource?
| "title": "hunger", | ||
| "type": "number", | ||
| "description": "Visual analogue scale. How hungry do you feel, at time minus 10 min Question: Hvor sulten er du?. Slider scale labels: Jeg er slet ikke sulten | | Jeg har aldrig været mere sulten", | ||
| "description": "Visual analogue scale. How hungry do you feel Question: Hvor sulten er du?. Slider scale labels: Jeg er slet ikke sulten | | Jeg har aldrig været mere sulten", |
Member
There was a problem hiding this comment.
The "Visual analogue scale. " can be removed from these descriptions. Also, can you add a regex replacer to put a period before Question: if there is no period?
github-project-automation
Bot
moved this from In review
to In progress
in Data development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
@martonvago Sorry this took longer than expected. Here is an attempt make changes to the script and the resulting differences in the
datapackage.jsonfile. All_XXminsuffixes are now removed and instead included as a variable. Don't hesitate to let me know if I missunderstood something from the issue.Closes #45
This PR needs a quick/an in-depth review.
Checklist
just run-all