feat: ✨ add ability to download data dict from REDCap#33
feat: ✨ add ability to download data dict from REDCap#33martonvago wants to merge 9 commits intomainfrom
Conversation
scripts/redcap.py
Outdated
|
|
||
| def get_data_dict_from_redcap() -> dict[str, str]: | ||
| """Gets the data dictionary from REDCap.""" | ||
| token = os.environ.get("REDCAP_TOKEN") |
There was a problem hiding this comment.
Currently, the token has CPH_API_KEY in the name on GenomeDK. Should we keep the reference to CPH? I went with a more general name here.
There was a problem hiding this comment.
I think for the generic code we should use the more general name, for the implementation of this code on ON LiMiT Feasibility we'll need to know that this is the code for the instance on REDCap in Copenhagen. Later there will be tokens for Copenhagen, Aarhus and Odense.
There was a problem hiding this comment.
Will all the locations be in the same repo or different repos?
There was a problem hiding this comment.
All the REDCap locations will pull into this one Data Package repo, as far I know.
There was a problem hiding this comment.
Ah okay! The metadata will be exactly the same, right (it's enough to get it from one location)? Then I will change the token name back to the CPH-specific one.
There was a problem hiding this comment.
For feasibility the only instance that we will be pulling 'real' data from is the Copenhagen one, but for testing we should be able to use the Aarhus version. I'm not sure we should be testing the data transfer with real data to start with. It would have been easier if we had some time to run tests on the system in Cph before we went into production, hopefully we'll have that for the main study.
The main study is still being designed, but it does look like we'll run several REDCap instances on the Aarhus server, each with slightly different data dictionaries...
lwjohnst86
left a comment
lwjohnst86
left a comment
There was a problem hiding this comment.
Nice, just some minor comments
scripts/redcap.py
Outdated
|
|
||
| def get_data_dict_from_redcap() -> dict[str, str]: | ||
| """Gets the data dictionary from REDCap.""" | ||
| token = os.environ.get("REDCAP_TOKEN") |
There was a problem hiding this comment.
All the REDCap locations will pull into this one Data Package repo, as far I know.
github-project-automation
bot
moved this from In Review
to In Progress
in Data development
|
@martonvago you can also include the downloaded |
@lwjohnst86 as in include it in the repo? Oh I'm stupid I was thinking why would I include the test metadata. But you meant the real metadata 🤦 |
|
@lwjohnst86 Done! |
3 participants
Description
This PR adds the ability to download the data dict from REDCap.
Closes #24
This PR needs an in-depth review.
Checklist
just run-all